Checklist of pull request approval by Eclipse Che QE team

1. Definition-Of-Done (DoD) is clear: feature specification / bug use case described and available for review.

2. If DoD achievement verification requires creation of new E2E selenium tests or updating existed ones - they have to be created or updated.

3. Code should has latest changes from the master branch before start E2E selenium tests.

4. There are no changes in the code in pull request after E2E selenium tests execution was requested.

5. Coverage of new or updated functionality by unit-tests >= 80%. We can use Cobertura maven plugin to measure coverage - next command generate Cobertura report: mvn cobertura:cobertura

6. Execution of E2E selenium tests for Eclipse Che Multiuser on OCP (command ci-test in comment to the pull request to run selenium tests on https://ci.codenvycorp.com/view/pr-builds/job/che-pullrequests-test-ocp/) shows:

   6.1 Success rate about 100% for existed E2E selenium tests without regression;

   6.2 Success rate equals to 100% for the new/updated E2E selenium tests.

7. If pull request creator decides that changes influence other distributions of Eclipse Che, E2E selenium tests we should be executed for them as well:

   7.1 Command ci-test-docker-single -> Single-User Eclipse Che on Docker

   7.2 Command ci-test-docker-multi -> Multi-User Eclipse Che on Docker (hasn't been implemented yet https://github.com/eclipse/che/issues/9566)

   7.3 Command ci-test-ocp-single -> Single-User Eclipse Che on OCP (hasn't been implemented yet https://github.com/eclipse/che/issues/9567)

8. Actually, E2E selenium tests cover about 50% of functionality of Eclipse Che upstream. There is a list of features which are not covered by E2E selenium tests.

9. There are some tests which require special configuration of product and don't run by ci-test commands on Pull Requests:

• Hot workspace update E2E selenium tests
• Creation of OpenShift objects under the current user account on OCP E2E selenium tests