Workspace.next - CheService model adjustment

[l0rd]

We knew that the phase 1 w.next model was not perfect and that some incremental updates would be needed. With that in mind we have identified a flaw in current CheService implementation and should be refactored.

Refactoring proposal

• Rename CheService as DevTool
• Rename Container as CheContainer
• Move Servers list from Container to DevTool and renamed it as DevToolEndpoints
• Exposed port in a container should be represented as CheContainerPort and have a matching DevToolEndpoint..targetPort
• Collapse CheServiceSpec in CheService
• Add an id field for DevTool to be referenced in CheFeature

Plantuml source

[l0rd]

cc @skabashnyuk @garagatyi

[skabashnyuk]

@l0rd about Add an id field for DevTool to be referenced in CheFeature AFAIK we talk about using id in routes and service discovering techniques. For the referencing purposes, we are going to use name and version.

[l0rd]

@garagatyi I have updated the model to use the name ChePlugin instead of DevTool. We will need to introduce the CheEditor and to remove CheFeature from the model. But I think it's ok to postpone these 2 steps as part of the walking skelethon epic.

[garagatyi]

We decided to remove name field from CheContainer since it is not needed now. If we find that we need it we will be able to add it back.

[garagatyi]

@l0rd do we really want that ChePluginEndpoint contain field isPublic instead of public? I'm OK with that, just want to clarify

[benoitf]

I don't remember where I said it but I raised same issue, public is shorter (than isPublic)