Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Theia in Workspace.Next workspaces #9870

Closed
garagatyi opened this issue May 30, 2018 · 4 comments
Closed

Load Theia in Workspace.Next workspaces #9870

garagatyi opened this issue May 30, 2018 · 4 comments
Assignees
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@garagatyi
Copy link

Description

PR #9774 brings an ability to try Workspace.Next in action. But workspaces with Theia feature don't load Theia IDE on start. We need to figure out how to change workspace loader component to allow it open Theia IDE if there is a runtime server corresponding to it.
FYI, for now, workspace loader seeks for Theia server in workspace configuration only.

Reproduction Steps

OS and version:

Diagnostics:

@garagatyi garagatyi added the kind/task Internal things, technical debt, and to-do tasks to be performed. label May 30, 2018
@skabashnyuk
Copy link
Contributor

skabashnyuk commented May 30, 2018

@garagatyi

But workspaces with Theia feature don't load Theia IDE on start.

Any ideas why?

@garagatyi
Copy link
Author

Because workspace loader app scans workspace config for Theia server. And we don't have it in workspace next. Instead, we will have that server in runtime field but not on the very start of a workspace.

@ashumilova ashumilova self-assigned this May 31, 2018
@ashumilova ashumilova added sprint/current status/in-progress This issue has been taken by an engineer and is under active development. and removed sprint/next labels Jun 7, 2018
@l0rd
Copy link
Contributor

l0rd commented Jun 20, 2018

@ashumilova are you going to work on that issue during current sprint?

@ashumilova
Copy link
Contributor

@l0rd yes, it's in progress, facing some environment issues - but doable.

@l0rd l0rd mentioned this issue Jun 29, 2018
24 tasks
@ashumilova ashumilova added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Jul 4, 2018
@ashumilova ashumilova removed sprint/current status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

4 participants