Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace is not started automatically from Dashboard after clicking "Open in IDE" button #9381

Closed
ibuziuk opened this issue Apr 11, 2018 · 6 comments
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Apr 11, 2018

I suspect there is some problem / race condition with starting workspace - was able to reproduce the problem against https://rhche.openshift.io/dashboard/#/ dashboard:

  1. Create workspace against vert.x stack
  2. Press "Open in IDE" button:
    image
  3. ERROR: Workspace is not starting
    image
  4. Press "Start" -> workspace is successfully started

NOTE: che.workspace.auto_start is set to false for rh-che deployment, not sure if it is expected but IMO if user press Open in IDE button workspace should be started in anycase (the property should only handle the case of direct opening of the workspace URL e.g from bookmark ). Description of the property:

# By default, when users access to a workspace with its URL the workspace
# automatically starts if it is stopped. You can set this to false to disable this.
che.workspace.auto_start=true 
@ibuziuk ibuziuk added kind/bug Outline of a bug - must adhere to the bug report template. target/che6 labels Apr 11, 2018
@ibuziuk ibuziuk added the kind/question Questions that haven't been identified as being feature requests or bugs. label Apr 11, 2018
@garagatyi
Copy link

@vparfonov has IDE changed its behavior since Che5 in such cases?

@ghost
Copy link

ghost commented Apr 13, 2018

@ibuziuk this is expected behavior since auto start is set to false and the IDE does not start a workspace. Open in IDE just opens IDE link i think but not actually initiates a POST request to start ws.

I do not have this problem with upstream Che

@ibuziuk
Copy link
Member Author

ibuziuk commented Apr 13, 2018

@eivantsov yeah, I wrote about it in the issue description.

NOTE: che.workspace.auto_start is set to false for rh-che deployment, not sure if it is expected but IMO if user press Open in IDE button workspace should be started in anycase (the property should only handle the case of direct opening of the workspace URL e.g from bookmark ).

IMO "Open in IDE" should start workspace in any case regardless of the che.workspace.auto_start property if we are planning to leave dashboard on osio

@ghost
Copy link

ghost commented Apr 13, 2018

Has @ashumilova had her say already?

@ibuziuk
Copy link
Member Author

ibuziuk commented Apr 18, 2018

after thinking more about the problem I now started to doubt why che.workspace.auto_start is needed at all in Che 6 (e.g. which usecase are we trying to handle with it). Please, comment in redhat-developer/rh-che#629 (comment)
if there are some concerns I'm missing

@ibuziuk
Copy link
Member Author

ibuziuk commented Aug 8, 2019

Closing as outdated

@ibuziuk ibuziuk closed this as completed Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants