Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Notification Manager Plugin API #9284

Closed
4 tasks done
ashumilova opened this issue Mar 28, 2018 · 3 comments
Closed
4 tasks done

Introduce Notification Manager Plugin API #9284

ashumilova opened this issue Mar 28, 2018 · 3 comments
Assignees
@olexii4
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@ashumilova
Copy link
Contributor

ashumilova commented Mar 28, 2018 •
edited by olexii4
Loading

The new plugin model should contain API for accessing Notification Manager from Theia core. The task includes following items to be done:

  • define the API of the Notification Manager
  • document the API
  • develop the defined API
  • test it on the sample plugin
@ashumilova ashumilova added status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/current team/ide2 labels Mar 28, 2018
This was referenced Mar 28, 2018
Closed
Closed
@olexii4 olexii4 added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Apr 6, 2018
@olexii4 olexii4 self-assigned this Apr 6, 2018
@ashumilova ashumilova added severity/P1 Has a major impact to usage or development of the system. and removed severity/P1 Has a major impact to usage or development of the system. labels Apr 12, 2018
@benoitf
Copy link
Contributor

benoitf commented Apr 16, 2018

hello, how is looking like the api ?
theia.window.showInformationMessage / theia.window.showWarningMessage / theia.window.showErrorMessage ?

@olexii4
Copy link
Contributor

olexii4 commented Apr 16, 2018 •
edited
Loading

Hello
Yes. It looks like:
showInformationMessage<T extends MessageItem>(message: string, ...items: T[]): PromiseLike<T | undefined>;
...

@olexii4 olexii4 added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Apr 23, 2018
@olexii4
Copy link
Contributor

olexii4 commented Apr 23, 2018

theia-demo-plugins/wiptheia#2

@ashumilova ashumilova removed sprint/current status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olexii4 olexii4

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benoitf @ashumilova @olexii4