Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run separate instance of Theia server with plugin that is developing #9212

Closed
ashumilova opened this issue Mar 23, 2018 · 10 comments
Closed
Assignees
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@ashumilova
Copy link
Contributor

When user develops Theia plugin in Che - there are should be an ability to configure and run separate instance of Theia with current plugin inside. For such development mode - a new “tab browser” with a new instance of Theia running should be opened.

@ashumilova ashumilova added status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. kind/task Internal things, technical debt, and to-do tasks to be performed. team/ide2 labels Mar 23, 2018
@mmorhun mmorhun self-assigned this Mar 28, 2018
@mmorhun mmorhun added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Mar 29, 2018
@benoitf
Copy link
Contributor

benoitf commented Mar 29, 2018

workflow is when developping a theia plugin new theia plugin model (not an extension) ?

@mmorhun
Copy link
Contributor

mmorhun commented Mar 29, 2018

Yes, this issue is only for new Theia plugin model.

@mmorhun
Copy link
Contributor

mmorhun commented Apr 6, 2018

Small clarification about implementation. This is supposed to work with new plugin model, as was said above. Because new plugin model is an extension (not plugin) of Theia we have to do this issue on the same level, i.e. extension. Theia supports both browser and electron versions, so we have to do the same here.
As about Che specific implementation (will be another extension not for Theia upstream) which will be added only in Theia inside Che workspaces, we may (for now it's the plan) do only browser implementation.

@benoitf
Copy link
Contributor

benoitf commented Apr 6, 2018

Hello,
I'm not sure to fully understand "Because new plugin model is an extension (not plugin) of Theia we have to do this issue on the same level, i.e. extension."

plugin is new isolated model, extension is the inversify extension (current theia extension model)

@mmorhun
Copy link
Contributor

mmorhun commented Apr 6, 2018

This issue is a part of new plugin model implementation. It handles new plugins, but has to be implemented as current theia extension and contributed in Theia core (because we support running Theia without Che)

@benoitf
Copy link
Contributor

benoitf commented Apr 6, 2018

I'm not sure to see why we're forced to use extension model instead of plugin model.
Writing plugin model requires to use extension model but plugin model will be part of theia (not che) so AFAIK we can pickup any model that we want when we want to provide stuff on top of Theia

@mmorhun
Copy link
Contributor

mmorhun commented Apr 6, 2018

Writing plugin model requires to use extension

That's what I wanted to say there:

Because new plugin model is an extension (not plugin) of Theia we have to do this issue on the same level, i.e. extension

@mmorhun
Copy link
Contributor

mmorhun commented Apr 6, 2018

AFAIK we can pickup any model that we want when we want to provide stuff on top of Theia

In general yes, but when we work on plugin model (this issue as a part of the epic):

Writing plugin model requires to use extension

@sunix
Copy link
Contributor

sunix commented Apr 6, 2018

I think there is something missing between this issue and the plugin model implementation. This issue is about running another theia with plugins that are in development the workspace to be tested in the browser:

For such development mode - a new “tab browser” with a new instance of Theia running should be opened.

if you are working on the plugin model implementation you should create a subtask or link to the related issue.
if you are working in the electron flow, it needs to be done as part of another issue as well IMHO

@mmorhun
Copy link
Contributor

mmorhun commented May 11, 2018

Done for Theia without Che.
For OCP we have separate issue: #9676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

4 participants