Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Docker API version to latest supported in Docker 1.11 #7496

Closed
garagatyi opened this issue Nov 21, 2017 · 4 comments · Fixed by #8238
Closed

Upgrade Docker API version to latest supported in Docker 1.11 #7496

garagatyi opened this issue Nov 21, 2017 · 4 comments · Fixed by #8238
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.

Comments

@garagatyi
Copy link

Description

Our Docker client uses Docker API version 1.20.
According to our docs minimal Docker version is 1.11.
So we can upgrade Docker API version to be able to use more features and more modern API 1.23.

Reproduction Steps

OS and version:

Diagnostics:
@garagatyi garagatyi added kind/task Internal things, technical debt, and to-do tasks to be performed. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. target/che6 labels Nov 21, 2017
@garagatyi
Copy link
Author

@eivantsov FYI

@skabashnyuk
Copy link
Contributor

I'm proposing Docker 17.04.0-ce release 04/03/2017 API version 1.28.

@riuvshin
Copy link
Contributor

update to 1.23 is safe because we don't change minimal docker engine version, but update to 1.28 could be a problem, because for example, RHEL / CentOShave own packaging of docker which still 1.12.x so we could have issues with running on it.

@skabashnyuk
Copy link
Contributor

@riuvshin @garagatyi Make sense I agree with you.

@mshaposhnik mshaposhnik mentioned this issue Jan 11, 2018
Merged
@ericwill ericwill mentioned this issue Apr 22, 2020
Closed
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Docker API version to latest supported by current Docker version eclipse-che/che
3 participants
@skabashnyuk @riuvshin @garagatyi