Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening large file crashes browser #5189

Closed
davidwindell opened this issue May 24, 2017 · 8 comments
Closed

Opening large file crashes browser #5189

davidwindell opened this issue May 24, 2017 · 8 comments
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage.

Comments

@davidwindell
Copy link
Contributor

Opening (or copying and pasting) a large file into Che will crash the browser tab.

Reproduction Steps:
Upload the file below from the AWS SDK into a Che project and try to open it.

https://raw.githubusercontent.com/aws/aws-sdk-php/master/src/data/iam/2010-05-08/api-2.json.php

OS and version:
Eclipse Che 5.10.0

@ghost ghost added kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. team/ide labels May 24, 2017
@ghost
Copy link

ghost commented Jul 12, 2017

@vparfonov should we investigate? Che used to handle big files quite gracefully.

@davidwindell
Copy link
Contributor Author

Still experiencing this in 5.15, also > 2000 lines in a file crashes the browser.

@davidwindell
Copy link
Contributor Author

This is still crashing in 5.19

@RomanNikitenko RomanNikitenko added the status/in-progress This issue has been taken by an engineer and is under active development. label Oct 17, 2017
@RomanNikitenko
Copy link
Member

I've investigated this bug, cause of the problem is: file has very long lines and originally this is bug of Orion

@RomanNikitenko RomanNikitenko removed the status/in-progress This issue has been taken by an engineer and is under active development. label Oct 18, 2017
@artaleks9
Copy link
Contributor

Still actual for ver.6.5.0

@vkuznyetsov vkuznyetsov added the status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. label Jul 11, 2018
@skabashnyuk
Copy link
Contributor

@vkuznyetsov why you consider this issue as a blocker?

@ghost
Copy link

ghost commented Aug 1, 2018

@vparfonov since this is a bug in Orion and it does not look like there will be a prompt resolution, why don't we at least warn a user trying to open such a file? Smth like a popup with a warning: File $filename contains abnormally long lines which may result in IDE freezing

Monaco editor in Theia seems to handle such files without any issues.

@vparfonov
Copy link
Contributor

not actual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage.
Projects
None yet
Development

No branches or pull requests

8 participants