Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update xterm.js to the latest version. #4251

Closed
AndrienkoAleksandr opened this issue Feb 28, 2017 · 4 comments
Closed

Update xterm.js to the latest version. #4251

AndrienkoAleksandr opened this issue Feb 28, 2017 · 4 comments
Assignees
@AndrienkoAleksandr
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Milestone
5.7.0

Comments

@AndrienkoAleksandr
Copy link
Contributor

AndrienkoAleksandr commented Feb 28, 2017 •
edited
Loading

We should update xterm.js to the latest version for bug fixing.
This issue consist of steps:
create and pass cq.
add latest xterm.js souce code to CHE.
update gulp tasks to build xterm.js and maybe fix some new css styles.
Apply our custom changes.
@AndrienkoAleksandr AndrienkoAleksandr added kind/task Internal things, technical debt, and to-do tasks to be performed. team/enterprise labels Feb 28, 2017
@AndrienkoAleksandr AndrienkoAleksandr self-assigned this Feb 28, 2017
@AndrienkoAleksandr AndrienkoAleksandr mentioned this issue Feb 28, 2017
Closed
@AndrienkoAleksandr AndrienkoAleksandr added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Mar 2, 2017
@skabashnyuk
Copy link
Contributor

skabashnyuk commented Mar 6, 2017 •
edited
Loading

  • are you planning to approve test resources?
  • are you planning to move xcode related code to lib?

@vkuznyetsov vkuznyetsov added sprint/current status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Mar 15, 2017
@AndrienkoAleksandr
Copy link
Contributor Author

@skabashnyuk Yes, we will move terminal to lib (without tests.).

@AndrienkoAleksandr
Copy link
Contributor Author

I checked integration new version of the terminal to Eclipse CHE. For now this issue awaiting to approve CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=12882 .

This was referenced Mar 16, 2017
Merged
Merged
@AndrienkoAleksandr
Copy link
Contributor Author

CQ passed.

@AndrienkoAleksandr AndrienkoAleksandr added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Mar 16, 2017
@AndrienkoAleksandr AndrienkoAleksandr mentioned this issue Mar 25, 2017
Closed
@AndrienkoAleksandr AndrienkoAleksandr added this to the 5.7.0 milestone Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrienkoAleksandr AndrienkoAleksandr

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
5.7.0
Development

No branches or pull requests
3 participants
@skabashnyuk @vkuznyetsov @AndrienkoAleksandr