Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version mismatch in Eclipse Che repos: should be 7.77.0 after release of 7.76.0 #22646

Closed
3 of 4 tasks
dmytro-ndp opened this issue Oct 31, 2023 · 5 comments
Closed
3 of 4 tasks
Assignees
Labels
kind/release Issue dedicated to a release (content, status, related PR, go/nogo/problem discussion, etc.) kind/task Internal things, technical debt, and to-do tasks to be performed. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.

Comments

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Oct 31, 2023

Is your task related to a problem? Please describe

[Dmytro] There is outdated version Eclipse 7.76.0 in main branches, while 7.77.0 is expected after release of 7.76.0:

At the same time version is correct in the next repos:

Describe the solution you'd like

[Nick] Recently, GH action runners were updated to no longer include hub already installed, so GH actions that use hub need to explictly install it. For example, eclipse-che/che-devfile-registry#793

Additional context

It was che-bot who created MR with update to next in Eclipse Che repo: #22568 (comment)

@dmytro-ndp dmytro-ndp added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Oct 31, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 31, 2023
@dmytro-ndp dmytro-ndp added severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 31, 2023
@dmytro-ndp dmytro-ndp changed the title Version mismatch in Eclipse Che repos Fix version mismatch in Eclipse Che repos: should be 7.77.0 after release of 7.76.0 Oct 31, 2023
@tolusha
Copy link
Contributor

tolusha commented Oct 31, 2023

7.76.0 in che-operator

That's ok - the latest stable version is printed.

@dmytro-ndp
Copy link
Contributor Author

@tolusha : thanks for the notice.

@dmytro-ndp dmytro-ndp added the kind/release Issue dedicated to a release (content, status, related PR, go/nogo/problem discussion, etc.) label Oct 31, 2023
@svor
Copy link
Contributor

svor commented Nov 2, 2023

fix for devfile registry: eclipse-che/che-devfile-registry#793
cc @SDawley @mkuznyetsov

@nickboldt
Copy link
Contributor

nickboldt commented Nov 6, 2023

Better solution: devfile/devworkspace-operator@9fce312

The hub CLI has been removed from the Ubuntu 20.04 runner and is
intended to be replaced with the gh CLI. This commit adapts the
previous hub command to open a PR into a gh command that does the same.

-    lastCommitComment="$(git log -1 --pretty=%B)"
-    $DRY_RUN hub pull-request -f -m "${lastCommitComment}" -b "${CURRENT_BRANCH}" -h "${PR_BRANCH}"
+    $DRY_RUN gh pr create -f -B "${CURRENT_BRANCH}" -H "${PR_BRANCH}"

@mkuznyetsov
Copy link
Contributor

Next release will ensure that all versions are properly updated, closing this issue for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/release Issue dedicated to a release (content, status, related PR, go/nogo/problem discussion, etc.) kind/task Internal things, technical debt, and to-do tasks to be performed. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Projects
None yet
Development

No branches or pull requests

7 participants