Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI builds for che-incubator/configbump, including updated secrets #21988

Closed
5 tasks
Tracked by #22035
tolusha opened this issue Feb 6, 2023 · 18 comments · Fixed by eclipse-che/che-release#80
Closed
5 tasks
Tracked by #22035
Assignees
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che

Comments

@tolusha
Copy link
Contributor

tolusha commented Feb 6, 2023

Is your task related to a problem? Please describe

Currently there is no way to release a new version of che-incubator/configbump since release action fails [1] with the error message:

Run echo "${DOCKERHUB_PASSWORD}" | docker login *** --username "***" --password-stdin
  echo "${DOCKERHUB_PASSWORD}" | docker login *** --username "***" --password-stdin
  shell: /usr/bin/bash -e {0}
  env:
    DOCKERHUB_PASSWORD: ***
Error response from daemon: Get "https://***/v[2](https://github.com/che-incubator/configbump/actions/runs/4103246296/jobs/7077201012#step:6:2)/": unauthorized: Invalid Username or Password

Credentials are outdated.

[1] https://github.com/che-incubator/configbump/actions/runs/4103246296

Describe the solution you'd like

Stretch goals:

  • replace alpine-based Dockerfile with ubi8-micro based Dockerfile
  • downstream, update scripts to use new rhel8-based Dockerfile instead of rhel.Dockerfile, if it's no longer needed

Additional context

#21883

@tolusha tolusha added kind/task Internal things, technical debt, and to-do tasks to be performed. area/ci CI build and releases, PR testing, & whitelabel/productization issues labels Feb 6, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 6, 2023
@nickboldt nickboldt changed the title Update docker credentials secrets for che-incubator/configbump repository Enable CI builds for che-incubator/configbump, including updated secrets Feb 6, 2023
@nickboldt nickboldt added the severity/P1 Has a major impact to usage or development of the system. label Feb 6, 2023
@ibuziuk ibuziuk removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 6, 2023
@ibuziuk
Copy link
Member

ibuziuk commented Feb 6, 2023

@nickboldt could you please take a look? it is very weird to see DOCKERHUB_PASSWORD in the logs since I do believe we only publish images to quay.io

@nickboldt
Copy link
Contributor

nickboldt commented Feb 15, 2023

Note thas as part of this update, we could also switch from alpine to ubi8 as the base from which images are built.

Figure if no one has cared about configbump for >2yrs https://quay.io/repository/che-incubator/configbump?tab=tags it's time to update it so it can benefit from our weekly base image update checks/PR generation.

@tolusha
Copy link
Contributor Author

tolusha commented Feb 16, 2023

I think ubi8 is a heavier image than alphine, so I am against it.

@nickboldt
Copy link
Contributor

nickboldt commented Feb 16, 2023

we'd use ubi8 micro (under 30M), not the full 214M ubi8 image.

  • docker.io/library/alpine 3.12 5.87 MB
  • registry.access.redhat.com/ubi8-micro latest 28.5 MB
  • registry.access.redhat.com/ubi8-minimal latest 94.5 MB
  • registry.access.redhat.com/ubi8 latest 214 MB

@tolusha
Copy link
Contributor Author

tolusha commented Feb 16, 2023

Then micro is fine for me. ^)

@nickboldt
Copy link
Contributor

@dmytro-ndp has asked for something to do for Day of Learning / H&H so I've given him this issue to work on when he has time.

@l0rd l0rd mentioned this issue Mar 6, 2023
7 tasks
@nickboldt nickboldt mentioned this issue Mar 8, 2023
45 tasks
@dmytro-ndp
Copy link
Contributor

@nickboldt: did I understand it correctly, that you had suggested to change versioning of configbump from 0.1.0 to Eclipse Che version, like che-machine-exec?

@nickboldt
Copy link
Contributor

nickboldt commented Mar 20, 2023

Yeah, might as well align to the other che-incubator projects and make per-sprint releases simpler.

https://quay.io/repository/che-incubator/configbump?tab=tags
vs.
https://quay.io/repository/che-incubator/che-code?tab=tags&tag=7.62.0

To see how secrets are used, check out:

See also this tool to list names of secrets in a repo, or push updates to secrets https://github.com/nickboldt/github-secrets-generator

@nickboldt
Copy link
Contributor

Note as part of having CI builds we should verify that che-incubator/configbump#68 (review) is merged and triggers a new CI build

@nickboldt nickboldt mentioned this issue Mar 21, 2023
50 tasks
@ibuziuk ibuziuk added team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che sprint/current and removed sprint/next labels Mar 22, 2023
@dmytro-ndp dmytro-ndp added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Apr 4, 2023
@dmytro-ndp dmytro-ndp changed the title Enable CI builds for che-incubator/configbump, including updated secrets Not possible to use multiple Apr 5, 2023
@dmytro-ndp dmytro-ndp changed the title Not possible to use multiple Enable CI builds for che-incubator/configbump, including updated secrets Apr 5, 2023
@nickboldt
Copy link
Contributor

Is this still needed?

@tolusha
Copy link
Contributor Author

tolusha commented Aug 24, 2023

Yes, we need a way to build a fresh image. The latest one is 2 y.o
https://quay.io/repository/che-incubator/configbump?tab=tags

@nickboldt
Copy link
Contributor

@nickboldt
Copy link
Contributor

Vastly better:

image

However need to fix that CVE -- see https://github.com/che-incubator/configbump/pull/100/files

@nickboldt
Copy link
Contributor

nickboldt commented Sep 18, 2023

@nickboldt
Copy link
Contributor

When run from the 7.74.x branch (where I already pushed my changes) the job passed:

https://github.com/che-incubator/configbump/actions/runs/6226555508/job/16899641726

So the PR should be safe to merge now

@nickboldt
Copy link
Contributor

nickboldt commented Sep 18, 2023

Hmm. tag-release failed in https://github.com/che-incubator/configbump/actions/runs/6227605614 but passed in https://github.com/che-incubator/configbump/actions/runs/6226555508

will assume for now this is fixed and verify further next week for the 7.75 release, when we don't have an existing branch and tag to contend with.

@nickboldt
Copy link
Contributor

image

image

Resolving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che
Projects
None yet
5 participants