Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Che Smoke Test PR check for Che-Code repository #21789

Closed
azatsarynnyy opened this issue Oct 27, 2022 · 4 comments
Closed

Add Che Smoke Test PR check for Che-Code repository #21789

azatsarynnyy opened this issue Oct 27, 2022 · 4 comments
Assignees
Labels
area/editor/vscode Issues related to the Code OSS editor of Che area/qe area/quality-tiers kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs.

Comments

@azatsarynnyy
Copy link
Member

azatsarynnyy commented Oct 27, 2022

Is your task related to a problem? Please describe

Currently, there're PR checks in the Che-Code repository that run the upstream tests. But there's no PR check that would run the Happy Path tests for testing Che-specific functionality. So, the developer needs to check by hand if they didn't break anything Che-specific.

Describe the solution you'd like

Need to add a PR check that would run Happy Path Tests against the opened PR. It should be a required check to prevent merging the code introduces some regression.

Additional context

@azatsarynnyy azatsarynnyy added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. team/editors area/editor/vscode Issues related to the Code OSS editor of Che labels Oct 27, 2022
@l0rd l0rd mentioned this issue Oct 28, 2022
73 tasks
@dmytro-ndp
Copy link
Contributor

@azatsarynnyy : there is a plan to switch existed Che-Theia Happy path tests to VS Code Editor using https://github.com/redhat-developer/vscode-extension-tester library: #21463

PR: #21684

@l0rd l0rd changed the title Add the Happy Path PR check for Che-Code repository Add Che Smoke Test PR check for Che-Code repository Mar 6, 2023
@l0rd
Copy link
Contributor

l0rd commented Mar 6, 2023

I have changed the title to reflect that we want to run a smoke test rather than an happy path test.

@l0rd l0rd mentioned this issue Mar 6, 2023
7 tasks
@dmytro-ndp dmytro-ndp added the team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs. label Mar 16, 2023
@dmytro-ndp
Copy link
Contributor

There is Che-Code editor smoke test available for running: https://github.com/eclipse/che/blob/main/tests/e2e/specs/SmokeTest.spec.ts

Here an example of usage: https://github.com/eclipse-che/che-operator/blob/main/build/scripts/oc-tests/oc-test-happy-path.sh
(just need to replace EmptyWorkspace with SmokeTest)

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented May 18, 2023

https://github.com/eclipse-che/che-operator/blob/main/build/scripts/oc-tests/oc-test-happy-path.sh is the script to run smoke test on OpenShift CI - an alternative to GitHub Actions where minikube is available for deploy Eclipse Che to only.

There are also GitHub Actions to deploy Eclipse Che to minikube [1], but I am not sure if there is enough resources in there to start Eclipse Che workspace with VS Code Editor on board.

[1] https://github.com/che-incubator/?q=action&type=all&language=&sort=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/vscode Issues related to the Code OSS editor of Che area/qe area/quality-tiers kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs.
Projects
None yet
Development

No branches or pull requests

6 participants