Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify workspace pod schedulerName as an URL parameter #21420

Closed
l0rd opened this issue May 24, 2022 · 2 comments
Closed

Specify workspace pod schedulerName as an URL parameter #21420

l0rd opened this issue May 24, 2022 · 2 comments
Assignees
@ibuziuk
Labels
area/devworkspace-operator area/factory/dashboard Issues related to factories frontend (che user dashboard side) engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach

Comments

@l0rd
Copy link
Contributor

l0rd commented May 24, 2022 •
edited
Loading

Is your enhancement related to a problem? Please describe

There are some specialized Kubernetes scheduler that can improve workspaces performances. One example is Portworx Stork. To use those schedulers pod should reference them in the PodSpec.schedulerName field.

But it's currently not possible to specify workspace pods schedulerName. It's not a DW field or a Devfile attribute.

Describe the solution you'd like

Update the DevWorkspace API to allow the specification of a schedulerName. And add the possibility to use it as a parameter in a factory URL.
@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label May 24, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label May 24, 2022
@l0rd l0rd changed the title Allow to specify workspace pod schedulerName Specify workspace pod schedulerName May 24, 2022
@l0rd l0rd added engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. area/devworkspace-operator area/factory/dashboard Issues related to factories frontend (che user dashboard side) severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels May 24, 2022
@l0rd l0rd mentioned this issue Jun 2, 2022
Closed
@l0rd l0rd changed the title Specify workspace pod schedulerName Specify workspace pod schedulerName as an URL parameter Sep 16, 2022
@l0rd
Copy link
Contributor Author

l0rd commented Oct 20, 2022 •
edited
Loading

Fixed by Related to devfile/devworkspace-operator#944.

@ibuziuk ibuziuk mentioned this issue Nov 2, 2022
Closed
73 tasks
@ibuziuk ibuziuk self-assigned this Nov 3, 2022
@ibuziuk ibuziuk added the status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach label Nov 3, 2022
@ibuziuk
Copy link
Member

ibuziuk commented Nov 3, 2022

After some discussion, it was decided to opt for the CR property for the schedulerName configuration instead of URL parameter - #21803
Closing the issue, feel free to reopen

@ibuziuk ibuziuk closed this as completed Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibuziuk ibuziuk

Labels
area/devworkspace-operator area/factory/dashboard Issues related to factories frontend (che user dashboard side) engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@l0rd @ibuziuk @che-bot