Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Devfile v2 outer loop components of type image and kubernetes #21186

Closed
l0rd opened this issue Feb 20, 2022 · 8 comments
Closed

Support Devfile v2 outer loop components of type image and kubernetes #21186

l0rd opened this issue Feb 20, 2022 · 8 comments
Labels
area/dashboard area/editors kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach

Comments

@l0rd
Copy link
Contributor

l0rd commented Feb 20, 2022

Is your enhancement related to a problem? Please describe

Che currently ignores these component types although they are used in registry.devfile.io samples.

👉 Note that this issue is only about the “outer loop” implementation of these components. Outer loop means that the components are created after a workspace start-up to test in a prod like deployment. There is a separate issue for inner loop support.

A component is considered “outer loop” if any of these conditions apply (c.f. https://github.com/devfile/library/pull/127/files):

  • it’s associated to a command of type apply
  • it’s a kubernetes or openshift and has deployByDefault: false (the version of the spec is 2.2 or higher)
  • it’s an image (and do NOT have autoBuild: true) (the version of the spec is 2.2 or higher)

Describe the solution you'd like

Pre-process the Devfile to replace the outer loop component with an exec command:

  • kubernetes or openshift components are replaced with a kubectl apply or oc apply command in the dev component
  • image components are replaced with a command that does a build, in this case the command is configurable as there are multiple options like buildah, kaniko, docker build or oc start-build on OCP.

2 alternative approaches

The “outer loop” components replacement with exec commands can be a responsibility of the dashboard OR of the IDEs.

Plus if it’s done by the dashboard: it works for any IDE
Plus if it’s done by the IDEs: it works for scenarios without Che dashboard (i.e. k apply -f devworkspace.yaml)

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Feb 20, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 20, 2022
@l0rd l0rd added area/dashboard area/editor/theia Issues related to the che-theia IDE of Che area/editor/vscode Issues related to the Code OSS editor of Che area/editors severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. area/editor/theia Issues related to the che-theia IDE of Che area/editor/vscode Issues related to the Code OSS editor of Che labels Feb 20, 2022
@ibuziuk
Copy link
Member

ibuziuk commented Feb 23, 2022

from the architectural point of view, I would like to avoid adding more complexity to the dashboard and making it the "glue" / pre-processing component without which some of the DevWorkspace flows would not work (like in this particular case with the apply:component: commands)

@ibuziuk ibuziuk added the status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach label Feb 23, 2022
@che-bot
Copy link
Contributor

che-bot commented Aug 22, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 22, 2022
@l0rd
Copy link
Contributor Author

l0rd commented Aug 22, 2022

/remove-lifecycle stale

@l0rd
Copy link
Contributor Author

l0rd commented Aug 22, 2022

Added to #17883

@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 22, 2022
@che-bot
Copy link
Contributor

che-bot commented Feb 18, 2023

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 18, 2023
@l0rd l0rd removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 18, 2023
@che-bot
Copy link
Contributor

che-bot commented Aug 17, 2023

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 17, 2023
@che-bot che-bot closed this as completed Aug 24, 2023
@AObuchow
Copy link

/remove-lifecycle stale

@AObuchow AObuchow reopened this Aug 24, 2023
@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2023
@che-bot
Copy link
Contributor

che-bot commented Feb 20, 2024

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 20, 2024
@che-bot che-bot closed this as completed Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard area/editors kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach
Projects
None yet
Development

No branches or pull requests

4 participants