Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiroot + sparseCheckoutDir should have sparseCheckoutDir as a workspace root #19370

Closed
4 of 23 tasks
sunix opened this issue Mar 23, 2021 · 2 comments
Closed
4 of 23 tasks
Assignees
Labels
area/editors kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@sunix
Copy link
Contributor

sunix commented Mar 23, 2021

Part of #15529

Describe the bug

Enabling multiroot to the Quarkus devfile the Che devfile registry, the final project (sparseCheckoutDir is still not a workspace root. multiroot is taking.

https://github.com/eclipse/che-devfile-registry/blob/master/devfiles/quarkus/devfile.yaml#L11

projects:
  -
    name: quarkus-quickstarts
    source:
      type: git
      location: "https://github.com/quarkusio/quarkus-quickstarts.git"
      sparseCheckoutDir: getting-started
      branch: main

The default workspace root folder should be located in /projects/quarkus-quickstarts/getting-started.

I think we should consider sparseCheckoutDirs as workspace roots.

Another option is to be able to override root folders:
devfile/api#385

projects:
  - name: quarkus-quickstarts
    git:
      location: "https://github.com/quarkusio/quarkus-quickstarts.git"
      sparseCheckoutDirs: ['getting-started']
      branch: main
    roots: ['getting-started']

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Create a new workspace from the template Quarkus Rest API
  2. Turn on multiroot
  3. See the workspace root is /projects/quarkus-quickstarts/ which is not right.

Expected behavior

Workspace root folder should be /projects/quarkus-quickstarts/getting-started

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Selection_283

Installation method

  • chectl
    • provide a full command that was used to deploy Eclipse Che (including the output)
    • provide an output of chectl version command
  • OperatorHub
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • Dev Sandbox (workspaces.openshift.com)
  • other: please specify

Eclipse Che Logs

N/A

Additional context

N/A

@sunix sunix added the kind/bug Outline of a bug - must adhere to the bug report template. label Mar 23, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 23, 2021
@vzhukovs vzhukovs added area/editors severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 23, 2021
@l0rd
Copy link
Contributor

l0rd commented Mar 26, 2021

If we add roots to the spec, do we still need sparseCheckoutDir?

@che-bot
Copy link
Contributor

che-bot commented Oct 12, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 12, 2021
@che-bot che-bot closed this as completed Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editors kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants