Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up che-theia build: rely on multistage build as much as possible. #18969

Closed
sunix opened this issue Feb 4, 2021 · 6 comments
Closed

Clean up che-theia build: rely on multistage build as much as possible. #18969

sunix opened this issue Feb 4, 2021 · 6 comments
Assignees
@sunix
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@sunix
Copy link
Contributor

sunix commented Feb 4, 2021

Is your task related to a problem? Please describe.

I tried to build che-theia from my local laptop but failed :

  • Missing yarn command
  • At the moment, yarn installation was broken on Fedora
  • Missing g++

We are already doing most of the build in docker multistage builld, so I don't see any reason to keep this line:
https://github.com/eclipse/che-theia/blob/39b67042da45484b53af20ad1759ddaeaf19762c/build.sh#L16

Describe the solution you'd like

Remove the line https://github.com/eclipse/che-theia/blob/39b67042da45484b53af20ad1759ddaeaf19762c/build.sh#L16
And make sure everything is done and still working in existing multistage build.

Describe alternatives you've considered

N/A

Additional context

Selection_198

Selection_196
@sunix sunix added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Feb 4, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 4, 2021
@benoitf
Copy link
Contributor

benoitf commented Feb 4, 2021

I would say it's not so important as dogfooding is #1 priority and everything is setup in theia-dev image.

@sunix
Copy link
Contributor Author

sunix commented Feb 4, 2021

If we download the dependencies in the che-theia-dev build, it would benefit dogfooding UX: it won't redownload the dependencies each time you create a new workspace.

@azatsarynnyy azatsarynnyy added area/dev-experience severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Feb 4, 2021
@ericwill ericwill mentioned this issue Feb 4, 2021
Closed
35 tasks
@ericwill ericwill added this to the 7.27 milestone Feb 8, 2021
@benoitf
Copy link
Contributor

benoitf commented Feb 10, 2021

well if it's to address caching of dependencies, the title is wrong.

I think time should be spent on improving dogfooding, not setuping a local build as for development mode you'll probably loose too many times on all changes you do.

@benoitf
Copy link
Contributor

benoitf commented Feb 10, 2021

anyway, on your local computer, you could just have used quay.io/che-theia:dev image as well

@benoitf benoitf added area/editor/theia Issues related to the che-theia IDE of Che and removed area/dev-experience labels Feb 10, 2021
@ericwill ericwill mentioned this issue Feb 25, 2021
Closed
46 tasks
@ericwill ericwill modified the milestones: 7.27, 7.28 Mar 2, 2021
@ericwill ericwill removed this from the 7.28 milestone Mar 24, 2021
@che-bot
Copy link
Contributor

che-bot commented Sep 20, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 20, 2021
@svor svor removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 20, 2021
@che-bot
Copy link
Contributor

che-bot commented Mar 19, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 19, 2022
@che-bot che-bot closed this as completed Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunix sunix

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@benoitf @sunix @svor @azatsarynnyy @ericwill @che-bot