Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt telemetry functionality in Che Theia to single-host #18503

Closed
azatsarynnyy opened this issue Dec 1, 2020 · 6 comments · Fixed by eclipse-che/che-theia#945
Closed

Adapt telemetry functionality in Che Theia to single-host #18503

azatsarynnyy opened this issue Dec 1, 2020 · 6 comments · Fixed by eclipse-che/che-theia#945
Assignees
@azatsarynnyy
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.24

Comments

@azatsarynnyy
Copy link
Member

Is your task related to a problem? Please describe.

For telemetry purposes, Che Theia makes the requests to /che/client-ip service.
It should be adapted to single-host mode as the browser goes to the wrong service URL.

Describe the solution you'd like

Make Che Theia going to the correct URL for /che/client-ip requests.

Describe alternatives you've considered

Additional context
@azatsarynnyy azatsarynnyy added kind/task Internal things, technical debt, and to-do tasks to be performed. area/editor/theia Issues related to the che-theia IDE of Che labels Dec 1, 2020
@azatsarynnyy
Copy link
Member Author

Thanks @sleshchenko for reporting it.
@ibuziuk I'm not sure if it's a critical one for 7.23 or it can wait for 7.24?

@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 1, 2020
@ibuziuk
Copy link
Member

ibuziuk commented Dec 1, 2020

@azatsarynnyy yeah, I believe this is a fairly important one

@azatsarynnyy
Copy link
Member Author

Thanks @ibuziuk. Then, we'll try to make it for 7.23

@azatsarynnyy azatsarynnyy added this to the 7.23 milestone Dec 1, 2020
@azatsarynnyy azatsarynnyy added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 1, 2020
@azatsarynnyy azatsarynnyy mentioned this issue Dec 1, 2020
Closed
15 tasks
@ibuziuk
Copy link
Member

ibuziuk commented Dec 2, 2020

@azatsarynnyy thanks, but could you please what exactly is broken? it is overall telemetry events or only the ip identification?

@azatsarynnyy
Copy link
Member Author

@ibuziuk only the ip identification

@sleshchenko sleshchenko mentioned this issue Dec 4, 2020
Merged
5 tasks
@azatsarynnyy azatsarynnyy mentioned this issue Dec 4, 2020
Merged
9 tasks
@sleshchenko
Copy link
Member

Good to see the draft for fix already in place.
It's really critical since it makes tab loading all available resources and Theia Webview seems does not work because of that
Screenshot_20201208_130204

@azatsarynnyy azatsarynnyy mentioned this issue Dec 9, 2020
Closed
21 tasks
@azatsarynnyy azatsarynnyy modified the milestones: 7.23, 7.24 Dec 9, 2020
@azatsarynnyy azatsarynnyy self-assigned this Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azatsarynnyy azatsarynnyy

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.24
Development

Successfully merging a pull request may close this issue.

Adapt Telemetry Plug-in API to a single-host mode eclipse-che/che-theia
4 participants
@ibuziuk @azatsarynnyy @sleshchenko @che-bot