Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a name validation check when creating a new SSH key pair #18229

Closed
vinokurig opened this issue Oct 28, 2020 · 0 comments · Fixed by eclipse-che/che-theia#913
Closed

Add a name validation check when creating a new SSH key pair #18229

vinokurig opened this issue Oct 28, 2020 · 0 comments · Fixed by eclipse-che/che-theia#913
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.22

Comments

@vinokurig
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

When a workspace starts, all SSH keys are provisioned to kubernetes secrets and if an SSH key has an invalid name for a kubernetes secret, workspace fails to start, see #18206.

Describe the solution you'd like

Add a name validation check when creating / uploading an SSH key pair.

Describe alternatives you've considered

Additional context
@vinokurig vinokurig added kind/enhancement A feature request - must adhere to the feature request template. team/plugins labels Oct 28, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 28, 2020
@ericwill ericwill removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 28, 2020
@ericwill ericwill mentioned this issue Oct 28, 2020
Closed
29 tasks
@tolusha tolusha added the severity/P1 Has a major impact to usage or development of the system. label Oct 28, 2020
@ibuziuk ibuziuk mentioned this issue Oct 29, 2020
Closed
@vinokurig vinokurig mentioned this issue Nov 9, 2020
Merged
9 tasks
@ericwill ericwill added this to the 7.22 milestone Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.22
Development

Successfully merging a pull request may close this issue.

Add exact match to SSH key name validation regexp eclipse-che/che-theia
4 participants
@tolusha @ericwill @vinokurig @che-bot