Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ms-vscode plantUML extension to che #17916

Closed
gattytto opened this issue Sep 20, 2020 · 5 comments
Closed

Add ms-vscode plantUML extension to che #17916

gattytto opened this issue Sep 20, 2020 · 5 comments
Labels
area/plugins kind/enhancement A feature request - must adhere to the feature request template.

Comments

@gattytto
Copy link

gattytto commented Sep 20, 2020

I just forgot to create an issue, sidecar repo is already created (thank you @ericwill), I will close this issue when extension is added.

extension repo: https://github.com/qjebbs/vscode-plantuml
test sidecar source: https://github.com/gattytto/che-sidecar-plantuml

test devfile:

apiVersion: 1.0.0
metadata:
  generateName: che-plantuml-

components:
  - type: chePlugin
    reference: >-
      https://raw.githubusercontent.com/gattytto/cheplugins/master/plantuml/2.13.12/meta.yaml

unpublished quay image until pr is merged: https://pr-check-783-alpine-che-plugin-registry.surge.sh/v3/plugins/qjebbs/vscode-plantuml/latest/meta.yaml

meta yaml

apiVersion: v2
publisher: qjebbs
name: vscode-plantuml
version: latest
type: VS Code extension
displayName: PlantUML
title: PlantUML
description: Rich PlantUML support for Visual Studio Code.
icon: /v3/images/jebbs-plantuml-icon.png
category: Programming Languages
repository: https://github.com/qjebbs/vscode-plantuml.git
firstPublicationDate: '2020-08-06'
deprecate:
  automigrate: true
  migrateTo: jebbs/plantuml/latest
spec:
  containers:
    - image: quay.io/eclipse/che-plugin-sidecar:plantuml-4180443
      name: vscode-plantuml
      memoryLimit: 512Mi
  extensions:
    - https://open-vsx.org/api/jebbs/plantuml/2.13.12/file/jebbs.plantuml-2.13.12.vsix
latestUpdateDate: "2020-12-23"

image
image

@gattytto gattytto added the kind/enhancement A feature request - must adhere to the feature request template. label Sep 20, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 20, 2020
@sunix
Copy link
Contributor

sunix commented Sep 21, 2020

@ericwill ericwill added area/plugins and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 21, 2020
@gattytto
Copy link
Author

gattytto commented Sep 25, 2020

live preview update works after workaround yay
image

@ericwill ericwill added the status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. label Sep 30, 2020
@ericwill
Copy link
Contributor

Blocked by #17931

@azatsarynnyy
Copy link
Member

FYI: the corresponding issue has been recently fixed - #16870

@gattytto gattytto removed the status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. label Dec 24, 2020
@gattytto
Copy link
Author

Closed By: eclipse-che/che-plugin-registry#865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants