Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to display images instead of product name #14845

Closed
vitaliy-guliy opened this issue Oct 10, 2019 · 3 comments
Closed

Allow to display images instead of product name #14845

vitaliy-guliy opened this issue Oct 10, 2019 · 3 comments
Assignees
@vitaliy-guliy
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering.

Comments

@vitaliy-guliy
Copy link
Contributor

vitaliy-guliy commented Oct 10, 2019 •
edited
Loading

Is your enhancement related to a problem? Please describe.

For CodeReady Workspaces it's better to display images next to the logo.
Displaying Red Hat CodeReady Workspaces looks not good.

The solution is to make it possible to display images next to the logo to be able to display images

https://github.com/redhat-developer/codeready-workspaces/blob/master/product/branding/CRW_SaaS_Wordmark_black.svg

It should be theme dependent.

Subtask for #14110
@vitaliy-guliy vitaliy-guliy added kind/enhancement A feature request - must adhere to the feature request template. team/ide2 area/editor/theia Issues related to the che-theia IDE of Che labels Oct 10, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 10, 2019
@vitaliy-guliy vitaliy-guliy mentioned this issue Oct 10, 2019
Closed
4 tasks
@tsmaeder tsmaeder added severity/P2 Has a minor but important impact to the usage or development of the system. status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 10, 2019
@tsmaeder
Copy link
Contributor

@vitaliy-guliy why is this an upstream issue and now in the crw jira? Also, do I understand correctly, that you just want to replace the image with a different one?

@tsmaeder tsmaeder removed the severity/P2 Has a minor but important impact to the usage or development of the system. label Oct 10, 2019
@vitaliy-guliy
Copy link
Contributor Author

@tsmaeder actually it's a subtask for this #14110

@vitaliy-guliy
Copy link
Contributor Author

It has to be fixed in the current sprint.

@vitaliy-guliy vitaliy-guliy mentioned this issue Oct 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitaliy-guliy vitaliy-guliy

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vitaliy-guliy @tsmaeder @che-bot