Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for remote plugin webview resources #14444

Closed
mmorhun opened this issue Sep 6, 2019 · 3 comments
Closed

Add support for remote plugin webview resources #14444

mmorhun opened this issue Sep 6, 2019 · 3 comments
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@mmorhun
Copy link
Contributor

mmorhun commented Sep 6, 2019 •
edited
Loading

Describe the bug

If remote plugin uses webview, it cannot access its resources.

Steps to reproduce

Add a remote plugin which uses webview with some resources, like images, css.
Welcome plugin is a good example of such a plugin.

Expected behavior

All images and styles are applied

Screenshots

remotes

Additional context

Resources for remoute plugins is handled by #13750, but resources for webview are treated differently, so should be handled separately.
@mmorhun mmorhun added kind/bug Outline of a bug - must adhere to the bug report template. kind/enhancement A feature request - must adhere to the feature request template. area/editor/theia Issues related to the che-theia IDE of Che labels Sep 6, 2019
@mmorhun mmorhun mentioned this issue Sep 6, 2019
Merged
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 6, 2019
@ibuziuk ibuziuk added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 9, 2019
@mmorhun mmorhun mentioned this issue Jan 20, 2020
Closed
3 tasks
@che-bot
Copy link
Contributor

che-bot commented Mar 11, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 11, 2020
@mmorhun
Copy link
Contributor Author

mmorhun commented Mar 12, 2020

I think it is not fixed yet.

@mmorhun mmorhun removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 12, 2020
@azatsarynnyy
Copy link
Member

Closing this as a duplicate of #16870. The latter one contains more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ibuziuk @azatsarynnyy @mmorhun @che-bot