Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosave for a devfile works incorrectly #14348

Closed
4 of 23 tasks
olexii4 opened this issue Aug 28, 2019 · 5 comments
Closed
4 of 23 tasks

Autosave for a devfile works incorrectly #14348

olexii4 opened this issue Aug 28, 2019 · 5 comments

Comments

@olexii4
Copy link
Contributor

olexii4 commented Aug 28, 2019

Describe the bug

Autosave for a devfile works incorrectly.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Create a new workspace from the devfile
metadata:
  name: wksp-test
apiVersion: 1.0.0
  1. Open 'Devfile' tab

  2. Simulate a case when you tried to add a new editor component but did not manage to finish in time:

  • Paste the following content
metadata:
  name: wksp-test
apiVersion: 1.0.0
components:
  - name: theia
    type: 
  • Wait until autosave will be triggered and an error appeared.

Expected behavior

Devfile content is not updated until the user does not finish typing.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Screenshot from 2019-08-28 13-53-45
Screenshot from 2019-08-28 13-54-44
Screenshot from 2019-08-28 13-55-49

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context

I propose to add a possibility to configure autosave for devfile or turn it off.
Instead of autosave, I have a purpose to save the current state of the devfile editor(simple string) as a temporary workspace data and restore it after page reload

@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 28, 2019
@AndrienkoAleksandr
Copy link
Contributor

+1 Really annoying bug.

@sleshchenko
Copy link
Member

Looks like error messages on the first and the second screenshots must be improved on Che Server side. @olexii4 Could you please create a separate issue?

@olexii4
Copy link
Contributor Author

olexii4 commented Aug 28, 2019

@sleshchenko I have created
#14350

@amisevsk
Copy link
Contributor

Closely related (duplicate?): #13982

@tsmaeder
Copy link
Contributor

Duplicate of #13982

@tsmaeder tsmaeder marked this as a duplicate of #13982 Aug 29, 2019
@amisevsk amisevsk removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants