Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

References to commits are broken in Help -> About dialog #14092

Closed
4 of 23 tasks
RomanNikitenko opened this issue Aug 1, 2019 · 6 comments
Closed
4 of 23 tasks

References to commits are broken in Help -> About dialog #14092

RomanNikitenko opened this issue Aug 1, 2019 · 6 comments
Assignees
@mmorhun
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
7.4.0

Comments

@RomanNikitenko
Copy link
Member

Describe the bug

Help -> About dialog contains references for commits to theia and che-theia projects
The references are broken at the moment for master branch assembly (eclipse/che-theia:next)

Che version

  • latest
  • nightly
  • other: eclipse/che-theia:next

Steps to reproduce

  1. Add to a devfile the section:
- 
    alias: theia-editor
    reference: >-
      https://raw.githubusercontent.com/eclipse/che-plugin-registry/master/v3/plugins/eclipse/che-theia/next/meta.yaml
    type: cheEditor
  1. Start a workspace from the devfile
  2. Go to Help -> About dialog and try references to theia and che-theia projects
  3. You can see https://github.com/theia-ide/theia/commit/N/A in an address line of a browser and error: 404 Page not found

Expected behavior

The references link to relevant commits

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube v1.0.0
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

page_not_found

Installation method

  • chectl chectl/0.0.2-6d3894f linux-x64 node-v10.4.1
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context
@RomanNikitenko RomanNikitenko added the kind/bug Outline of a bug - must adhere to the bug report template. label Aug 1, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 1, 2019
@ibuziuk
Copy link
Member

ibuziuk commented Aug 1, 2019

@RomanNikitenko are you planning to work on this issue for Che 7 GA ?

@RomanNikitenko
Copy link
Member Author

The issue is relevant for eclipse/che-theia:next, so for master branch assembly, I don't think we need it for GA.

@ibuziuk
Copy link
Member

ibuziuk commented Aug 1, 2019

moving to 7.1.0 milestone

@ibuziuk ibuziuk added this to the 7.1.0 milestone Aug 1, 2019
@ibuziuk ibuziuk added team/ide2 and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 1, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 1, 2019
@benoitf benoitf removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 1, 2019
@ibuziuk ibuziuk added the severity/P1 Has a major impact to usage or development of the system. label Aug 1, 2019
@l0rd l0rd removed the severity/P1 Has a major impact to usage or development of the system. label Aug 2, 2019
@slemeur slemeur modified the milestones: 7.1.0, 7.2.0 Aug 2, 2019
@evidolob evidolob mentioned this issue Aug 7, 2019
Closed
26 tasks
@gorkem gorkem added the area/editor/theia Issues related to the che-theia IDE of Che label Aug 23, 2019
@evidolob evidolob mentioned this issue Aug 28, 2019
Closed
20 tasks
@sunix sunix added the severity/P2 Has a minor but important impact to the usage or development of the system. label Sep 4, 2019
@mmorhun mmorhun self-assigned this Sep 11, 2019
@mmorhun mmorhun mentioned this issue Sep 13, 2019
Merged
@mmorhun
Copy link
Contributor

mmorhun commented Sep 17, 2019

Fixed

@mmorhun mmorhun closed this as completed Sep 17, 2019
@RomanNikitenko
Copy link
Member Author

I can reproduce it again for che-theia commit reference: https://youtu.be/u3ZM5biGC_M

@mmorhun could you take a look?

@RomanNikitenko RomanNikitenko reopened this Oct 3, 2019
@evidolob evidolob modified the milestones: 7.2.0, 7.4.0 Oct 10, 2019
@evidolob evidolob mentioned this issue Oct 10, 2019
Closed
13 tasks
@mmorhun
Copy link
Contributor

mmorhun commented Oct 16, 2019

I think this is fixed again by eclipse-che/che-theia#487

@mmorhun mmorhun closed this as completed Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmorhun mmorhun

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
7.4.0
Development

No branches or pull requests
10 participants
@gorkem @benoitf @l0rd @sunix @evidolob @ibuziuk @slemeur @RomanNikitenko @mmorhun @che-bot