Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple Java selenium E2E tests from GWT-code #13827

Closed
21 tasks done
dmytro-ndp opened this issue Jul 12, 2019 · 7 comments
Closed
21 tasks done

Decouple Java selenium E2E tests from GWT-code #13827

dmytro-ndp opened this issue Jul 12, 2019 · 7 comments
Assignees
@SkorikSergey
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
Backlog - QE

Comments

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Jul 12, 2019 •
edited by SkorikSergey
Loading

Description

There is a plan to remove GWT-related code from Che #13788, and Java E2E selenium tests should be aligned with this changes:

  • step 1: fix build of Java E2E selenium tests: there are outdated dependencies:
  • org.eclipse.che.plugin:che-plugin-github-shared
  • org.eclipse.che.plugin:che-plugin-github-server
  • org.eclipse.che.core:che-core-api-debug-shared
  • step 2: remove the tests which aimed to verify GWT-editor functionality:
  • org.eclipse.che.selenium.assistant.*
  • org.eclipse.che.selenium.languageserver.*
  • org.eclipse.che.selenium.debugger.*
  • org.eclipse.che.selenium.editor.*
  • org.eclipse.che.selenium.filewatcher.*
  • org.eclipse.che.selenium.git.*
  • org.eclipse.che.selenium.intelligencecommand.*
  • org.eclipse.che.selenium.mavenplugin.*
  • org.eclipse.che.selenium.miscellaneous.*
  • org.eclipse.che.selenium.opendeclaration.*
  • org.eclipse.che.selenium.plainjava.*
  • org.eclipse.che.selenium.testrunner.*
  • org.eclipse.che.selenium.projectexplorer.*
  • org.eclipse.che.selenium.refactor.*
  • org.eclipse.che.selenium.stack.*
  • org.eclipse.che.selenium.workspaces.CheckStopStartWsTest
  • step 3: rewrite next Dashboard tests which use GWT-editor to check changes in Dashboard, sorted by priority:
    • org.eclipse.che.selenium.site.ocpoauth.LoginExistedUserWithOpenShiftOAuthTest
    • org.eclipse.che.selenium.site.ocpoauth.LoginNewUserWithOpenShiftOAuthTest
    • org.eclipse.che.selenium.git.AuthorizeOnGithubFromDashboardTest
    • org.eclipse.che.selenium.dashboard.DeleteRunningWorkspaceTest
    • org.eclipse.che.selenium.dashboard.DeleteStoppingWorkspaceTest
    • org.eclipse.che.selenium.dashboard.RenameWorkspaceTest
    • org.eclipse.che.selenium.dashboard.organization.ShareWorkspaceMemberTest
    • org.eclipse.che.selenium.dashboard.workspaces.details.WorkspaceDetailsOverviewTest
    • org.eclipse.che.selenium.workspaces.CheckStoppingWsByTimeoutTest
    • org.eclipse.che.selenium.workspaces.ProjectStateAfterRefreshTest
    • org.eclipse.che.selenium.workspaces.ProjectStateAfterWorkspaceRestartTest
    • org.eclipse.che.selenium.workspaces.ProjectStateAfterRenameWorkspaceTest
    • org.eclipse.che.selenium.hotupdate.recreate.RecreateUpdateStrategyTest
    • org.eclipse.che.selenium.hotupdate.rolling.RollingUpdateStrategyWithEditorTest
    • org.eclipse.che.selenium.hotupdate.rolling.RollingUpdateStrategyWithStartedWorkspaceTest
    • org.eclipse.che.selenium.dashboard.workspaces.WorkspacesListTest
    • org.eclipse.che.selenium.dashboard.workspaces.details.WorkspaceDetailsProjectsTest
    • org.eclipse.che.selenium.hotupdate.rolling.RollingUpdateStrategyWithWorkspacesStartStopTest
@dmytro-ndp dmytro-ndp added status/in-progress This issue has been taken by an engineer and is under active development. kind/task Internal things, technical debt, and to-do tasks to be performed. team/che-qe labels Jul 12, 2019
@dmytro-ndp dmytro-ndp mentioned this issue Jul 12, 2019
Merged
@rhopp rhopp added the severity/P1 Has a major impact to usage or development of the system. label Jul 12, 2019
@rhopp rhopp added this to the 7.0.0 milestone Jul 12, 2019
@dmytro-ndp dmytro-ndp self-assigned this Jul 12, 2019
@l0rd
Copy link
Contributor

l0rd commented Jul 15, 2019

How much work is required by "rewrite Dashboard tests which use GWT-editor to check changes in Dashboard."? It's more than half a day can we postpone it after GA?

@rhopp
Copy link
Contributor

rhopp commented Jul 15, 2019

I was thinking in this issue just in scope of Che 7 release - basically making the code "compilable" (that's why the che7GA target). I don't care much about the old tests and if something can be saved from existing tests with minimal amount of work, it should be done as part of different issue. I'll edit the description of this one and create another one for possible followup work.
Sorry for the confusion.

@rhopp
Copy link
Contributor

rhopp commented Jul 15, 2019

Thinking again about this... For Che7GA, disabling whole selenium module should be enough (which is already done as part of #13788) and this issue can be left as is, but postpone it post-GA.

@rhopp rhopp added severity/P2 Has a minor but important impact to the usage or development of the system. and removed severity/P1 Has a major impact to usage or development of the system. target/che7GA labels Jul 15, 2019
@rhopp rhopp modified the milestones: 7.0.0, 7.x Jul 15, 2019
@dmytro-ndp
Copy link
Contributor Author

@rhopp: if we disable Java selenium e2e tests, we will stop testing IDE Dashboard on regular basis.

@dmytro-ndp
Copy link
Contributor Author

dmytro-ndp commented Jul 15, 2019 •
edited
Loading

We can clean up and enable Java selenium tests, but disable particular tests which we are going to re-write (step 1, 2 from description). It's about several days of work, IMHO.

@rhopp
Copy link
Contributor

rhopp commented Jul 15, 2019

Right now I'm most interested in amount of test-cases which would work without any refactoring (after the build-time dependencies are removed).

@dmytro-ndp dmytro-ndp removed the status/in-progress This issue has been taken by an engineer and is under active development. label Jul 30, 2019
@rhopp rhopp mentioned this issue Aug 14, 2019
Closed
@SkorikSergey SkorikSergey added the status/in-progress This issue has been taken by an engineer and is under active development. label Aug 21, 2019
@vkuznyetsov vkuznyetsov mentioned this issue Sep 18, 2019
Closed
5 tasks
This was referenced Sep 19, 2019
Merged
Merged
@rhopp rhopp modified the milestones: 7.x, Backlog - QE Sep 23, 2019
@vkuznyetsov vkuznyetsov mentioned this issue Sep 26, 2019
Closed
17 tasks
@SkorikSergey SkorikSergey mentioned this issue Sep 30, 2019
Merged
@dmytro-ndp
Copy link
Contributor Author

dmytro-ndp commented Oct 1, 2019 •
edited
Loading

@SkorikSergey: FYI: Che rollout update docs https://www.eclipse.org/che/docs/che-6/kubernetes-admin-guide.html#updating-che-without-stopping-active-workspaces

@rhopp rhopp modified the milestones: Backlog - QE, 7.3.0 Oct 2, 2019
This was referenced Oct 3, 2019
Merged
Merged
@rhopp rhopp modified the milestones: 7.3.0, Backlog - QE Oct 16, 2019
@vkuznyetsov vkuznyetsov added status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. and removed status/in-progress This issue has been taken by an engineer and is under active development. sprint/current labels Oct 16, 2019
@SkorikSergey SkorikSergey added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Oct 24, 2019
@SkorikSergey SkorikSergey mentioned this issue Oct 24, 2019
Merged
@SkorikSergey SkorikSergey removed the status/in-progress This issue has been taken by an engineer and is under active development. label Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SkorikSergey SkorikSergey

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
Backlog - QE
Development

No branches or pull requests
5 participants
@l0rd @dmytro-ndp @rhopp @vkuznyetsov @SkorikSergey