-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workspace-loader doesn't recognize when workspace start fails immediately after start request is sent #13209
Labels
kind/bug
Outline of a bug - must adhere to the bug report template.
Comments
@vitaliy-guliy FYI |
Thanks! |
@akurinnoy Shouldn't this issue be reopened, as the commit was reverted? |
@rhopp sure, thanks! |
This was referenced Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When because of some reason workspace start request succeeds but start itself fails immediately after that wsmaster send event with error to subscribed websocket clients.

But workspace-loader doesn't receive it because it subscribes only after that message was already sent.
Which leads to a infinitely running loading screen with no error shown
It seems that workspace-loader subscribes to workspace status event after sending workspace start request, not before that.
Reproduction Steps
OS and version:
Diagnostics:
The text was updated successfully, but these errors were encountered: