-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support workspace creating from repository if it contains .devfile.yaml
/devfile.yaml
file
#12675
Comments
@l0rd @skabashnyuk WDYT? |
👍 YAML indentation can also be validated to avoid some basic mistakes |
@sleshchenko I amo 👍 for your proposal. But honestly the biggest issue for me is that no error is shown if a file
|
@lord That is because we still support this kind of factories which pointing to any GH repo, even without |
Thank you for your explanation @mshaposhnik but I don't think we should support that. It's really misleading. |
No problem, if it's decomissioning will be approved by @slemeur |
I'm -1 to remove that. In fact, that allows to import a project in Che with just a URL even if there is no devfile and factory. That allows flow like: We can't expect that the devfile will be define before the project gets imported in Che. It should be easy / simple to import in Che and requires the minimum of pre-requisities. Once the developer is in Che, we make the configuration of the workspace easy and allow the developer to version that with a devfile. Also, Che should be able to analyze the project, detect the technologies used and propose to the user a workspace that fits with his needs. |
Is not actual after merge of #12965 |
Description
Now, Factory API supports only repositories with Devfile if file name is
.devfile
https://github.com/eclipse/che/blob/7a9feef2b553fd20ffc85f2a53b8f38b2e75847f/plugins/plugin-github/che-plugin-github-factory-resolver/src/main/java/org/eclipse/che/plugin/github/factory/resolver/GithubURLParser.java#L93
But many editors do not enable YAML syntax highlighting if file name does not have format specified.
I think it is better to add support workspace creating from repository if it contains
.devfile.yaml
file.See how it affects displaying by Github
Without format specified:With format specified:
See how it affects displaying by Atom editor
Without format specified:
With format specified:
Actually, a user may want not to hide Devfile file from file managers, and it would be good to give a user choice and name Devfile as he wants - with dot or without at the begigging of name.
The text was updated successfully, but these errors were encountered: