Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gwt ide in sidecar is not working due to CORS configuration on ws-agent #12403

Closed
skabashnyuk opened this issue Jan 12, 2019 · 0 comments · Fixed by #12404
Closed

Gwt ide in sidecar is not working due to CORS configuration on ws-agent #12403

skabashnyuk opened this issue Jan 12, 2019 · 0 comments · Fixed by #12404
Labels
kind/bug Outline of a bug - must adhere to the bug report template.

Comments

@skabashnyuk
Copy link
Contributor

Description

Ws-agent by default set cors filter configuration to allow request only from che.api. But if gwt ide running as sidecar it loads IDE not from the master but from a different server running in the dedicated container.
We need to change default cors logic to be more similar to workspace loader. https://github.com/eclipse/che/blob/master/workspace-loader/src/index.ts#L349-L361
It should detect ide location from servers configuration or fallback to ide attribute of workspace configuration.

output

Reproduction Steps

  • Enable GWT Editor

16 19 26

  • Start workspace
  • Try to create project

16 06 38

  • In console you can see CORS errors
    16 06 20
@skabashnyuk skabashnyuk added the kind/bug Outline of a bug - must adhere to the bug report template. label Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant