Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workspace attributes should use plugin IDs rather than plugin name #11600

Closed
l0rd opened this issue Oct 11, 2018 · 0 comments · Fixed by #12615
Closed

Workspace attributes should use plugin IDs rather than plugin name #11600

l0rd opened this issue Oct 11, 2018 · 0 comments · Fixed by #12615
Assignees
@garagatyi
Labels
kind/bug Outline of a bug - must adhere to the bug report template.

Comments

@l0rd
Copy link
Contributor

l0rd commented Oct 11, 2018

Description

In Che 7 workspaces plugins memory setting can be set in the workspace attributes using the following syntax: sidecar.<plugin name>.memory_limit": "300Mi".

But <plugin name> can have spaces. We should use <plugin id> instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garagatyi garagatyi

Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
No milestone
3 participants
@l0rd @garagatyi @amisevsk