Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask a user to remove installer from a workspace when they enables WS.NEXT editor or plugin #11401

Closed
garagatyi opened this issue Sep 28, 2018 · 3 comments
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.

Comments

@garagatyi
Copy link

Description

Now we can enable WS.NEXT editor and plugins from UD. And we even have UI for that on the creation of a workspace. But this UI allows a user to enable WS.NEXT plugins without disabling Che 6 installers.
This PR would prevent the start of such a workspace and that would mean that UD would create invalid WS from UI.
It would be a way better UX if we adapt UD to these changes and show user pop-up dialog to remove installers from the workspace if the user tries to enable plugin/editor. We can also add a link to docs about that (they are missing for the time being as far as I know).

Reproduction Steps

OS and version:

Diagnostics:

@garagatyi garagatyi added the kind/bug Outline of a bug - must adhere to the bug report template. label Sep 28, 2018
@garagatyi
Copy link
Author

@ashumilova FYI

@l0rd l0rd mentioned this issue Sep 28, 2018
57 tasks
@l0rd l0rd changed the title Ask a user to remove installers from a workspace when they enables WS.NEXT editor or plugin Ask a user to remove installer from a workspace when they enables WS.NEXT editor or plugin Sep 29, 2018
@garagatyi
Copy link
Author

Fix from Angel was merged and now a workspace with plugins enabled on workspace creation view can't be created because server side doesn't allow to create a workspace with installers and plugins at the same time. Seems that we need to implement this issue to avoid this weird UX.
@ashumilova WDYT?

@ashumilova ashumilova self-assigned this Oct 3, 2018
@ashumilova ashumilova added the status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. label Oct 3, 2018
@ashumilova
Copy link
Contributor

we took to the current sprint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.
Projects
None yet
Development

No branches or pull requests

2 participants