Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of Github PR URLs to a git repo URL Factory #11045

Closed
garagatyi opened this issue Sep 3, 2018 · 2 comments
Closed

Add support of Github PR URLs to a git repo URL Factory #11045

garagatyi opened this issue Sep 3, 2018 · 2 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Milestone

Comments

@garagatyi
Copy link

Description

Che supports the creation of factories for a Github repo https://www.eclipse.org/che/docs/factories-getting-started.html#invoke-factory-for-a-specific-git-repo
We can add a new feature: support of PR URLs to this Factory capability.
For a link like https://che-url/factory?url=https://github.com/eclipse/che/pull/10740 we would apply a factory that clones git repo and checks out to a PR branch.
Note that there might be 2 kinds of repos for a PR:

We can implement one of the cases for the beginning and create a separate issue for another one, or we can implement both in the same contribution.

Reproduction Steps

OS and version:

Diagnostics:

@garagatyi garagatyi added the kind/enhancement A feature request - must adhere to the feature request template. label Sep 3, 2018
@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 7, 2018
@benoitf
Copy link
Contributor

benoitf commented Sep 7, 2018

PR provided handling both cases.
just a notice: it works only for Opened PR, it doesn't work on closed/merged PR (as branch may be gone)

@benoitf benoitf added this to the 6.12.0 milestone Sep 25, 2018
@benoitf
Copy link
Contributor

benoitf commented Sep 25, 2018

already merged

@benoitf benoitf closed this as completed Sep 25, 2018
@benoitf benoitf modified the milestones: 6.12.0, 6.11.0 Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Development

No branches or pull requests

2 participants