Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DTO field name custom serialization in che-plugin-broker event #10880

Closed
garagatyi opened this issue Aug 22, 2018 · 0 comments
Closed

Use DTO field name custom serialization in che-plugin-broker event #10880

garagatyi opened this issue Aug 22, 2018 · 0 comments
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@garagatyi
Copy link

Description

In the initial implementation of walking skeleton I stringified workspace tooling provided by che-plugin-broker to master in a JSON_RPC event because I thought that DTO doesn't support custom field names in serialization.
Then I figured out that DTO has this ability, so we need to rework this approach #10841 (comment)

Reproduction Steps

OS and version:

Diagnostics:
@garagatyi garagatyi added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Aug 22, 2018
@l0rd l0rd mentioned this issue Aug 22, 2018
Closed
57 tasks
@garagatyi garagatyi mentioned this issue Aug 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@garagatyi