Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add websocket reconnection feature to workspace loader app #10365

Closed
garagatyi opened this issue Jul 10, 2018 · 2 comments
Closed

Add websocket reconnection feature to workspace loader app #10365

garagatyi opened this issue Jul 10, 2018 · 2 comments
Assignees
@akurinnoy
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@garagatyi
Copy link

Description

Because of Ingress implementation details in k8s infra we have a situation when websocket connection from workspace-loader to master gets closed.
Since workspace-loader is using such a connection it gets stuck when this happens and doesn't open IDE when workspace becomes running.
UD handle this situation with automatic reconnection of a websocket. We need the same functionality in workspace-loader.
This leads to a broken workspace start on kubernetes infrastructure.

Reproduction Steps

OS and version:

Diagnostics:
@garagatyi
Copy link
Author

@ashumilova not sure how to qualify the issue - bug or task. Please, take a look and, if possible, take in the new sprint.

@l0rd l0rd mentioned this issue Jul 10, 2018
Closed
24 tasks
@ashumilova ashumilova mentioned this issue Jul 11, 2018
Closed
20 tasks
@ashumilova
Copy link
Contributor

need to try reconnecting-websocket library

@ashumilova ashumilova added sprint/current kind/task Internal things, technical debt, and to-do tasks to be performed. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Jul 11, 2018
@akurinnoy akurinnoy self-assigned this Jul 20, 2018
@akurinnoy akurinnoy added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Jul 20, 2018
@garagatyi garagatyi mentioned this issue Jul 21, 2018
Closed
@akurinnoy akurinnoy mentioned this issue Jul 25, 2018
Merged
@akurinnoy akurinnoy removed the status/in-progress This issue has been taken by an engineer and is under active development. label Jul 31, 2018
@l0rd l0rd mentioned this issue Aug 3, 2018
Closed
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akurinnoy akurinnoy

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ashumilova @garagatyi @akurinnoy