Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to Scandium for setting trusted RPKs #301

Closed
LudwigSeitz opened this issue May 4, 2017 · 8 comments
Closed

Add method to Scandium for setting trusted RPKs #301

LudwigSeitz opened this issue May 4, 2017 · 8 comments

Comments

@LudwigSeitz
Copy link

When doing a raw-public-key handshake according to RFC 7250 the raw public key of the other peer is said to be verified out-of-band.

I would like to have a feature in Scandium where I can add a list of trusted raw public keys, from which I will accept DTLS connections (and reject others).

@boaks
Copy link
Contributor

boaks commented May 4, 2017

Request offers getSenderIdentity, which provides the access to the raw public key.
So I think, you could check it on incoming request.

@LudwigSeitz
Copy link
Author

True, but it would be nice to be able to check this in Scandium and not in the application, so that the handshake is aborted.

@sophokles73
Copy link
Contributor

I agree, it would be nice to have something along the lines of the PSKStore for RPKs as well.

@LudwigSeitz
Copy link
Author

Referring to the comment from boaks: How do I check the same thing at the client side? The server's public key seems to be encapsulated in the ClientHandshaker and I cannot find an (obvious) method to access it at client side.

@LudwigSeitz
Copy link
Author

I've written some code to solve this issue, what is the preferred procedure for contributing this?

@boaks
Copy link
Contributor

boaks commented Oct 4, 2017

The raw public keys are used to create the RawPublicKeyIdentity (which implements Principal).
But your right, if the client sends application data, the application layer will not get the principal until the server replies. So, if you can't wait for the servers response, scandium must be enhanced.

I've written some code to solve this issue, what is the preferred procedure for contributing this?
That's defined by eclipse. A PR requires a ECA.

https://www.eclipse.org/legal/ECA.php

@LudwigSeitz
Copy link
Author

Did a pull request with code for that feature. Please review.

@boaks
Copy link
Contributor

boaks commented Nov 3, 2017

Should be solve with the merging of your PR.

@boaks boaks closed this as completed Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants