Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to export multiple files #31

Closed
jhchee opened this issue Feb 27, 2022 · 2 comments
Closed

Option to export multiple files #31

jhchee opened this issue Feb 27, 2022 · 2 comments

Comments

@jhchee
Copy link

jhchee commented Feb 27, 2022 •
edited
Loading

Hi @echo724, I discovered that when the markdown_exporter is called multiple times for different notion block id, the same notion block is being exported. I think the reason is that Config class being a singleton, is it possible to change this implementation?
@echo724
Copy link
Owner

echo724 commented Feb 27, 2022

Got it! I will fix it soon. Thank you.

echo724 added a commit that referenced this issue Mar 1, 2022
@echo724
fix: Remove Singleton pattern in Config class (#31)
2de75e3
github-actions bot pushed a commit that referenced this issue Mar 1, 2022
@semantic-release-bot
chore(release): 2.7.5 [skip ci]
a50f44f 
### [2.7.5](v2.7.4...v2.7.5) (2022-03-01)

### Bug Fixes

* Remove Singleton pattern in Config class ([#31](#31)) ([2de75e3](2de75e3))
@jhchee
Copy link
Author

jhchee commented Mar 13, 2022

@echo724 I can verify the Release 2.7.5 has fixed this problem for me. I think you can close the issue.

@echo724 echo724 closed this as completed Mar 16, 2022
YouXam pushed a commit to YouXam/notion2md that referenced this issue Nov 3, 2023
@echo724
fix: Remove Singleton pattern in Config class (echo724#31)
158184b
YouXam pushed a commit to YouXam/notion2md that referenced this issue Nov 3, 2023
@semantic-release-bot
chore(release): 2.7.5 [skip ci]
220d5c5 
### [2.7.5](echo724/notion2md@v2.7.4...v2.7.5) (2022-03-01)

### Bug Fixes

* Remove Singleton pattern in Config class ([echo724#31](echo724#31)) ([2de75e3](echo724@2de75e3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhchee @echo724