Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made doc corrections to clarify adding contract to taco shop react app config #1527

Merged
merged 4 commits into from
Nov 22, 2022

Conversation

michaelkernaghan
Copy link
Contributor

🌮 Taqueria PR

🪁 Description

The docs needed some clarification so the change could be made without a linter error
CLOSE #1478

🪂 Pre-Merge Checklist (Definition of Done)

🚦 Required to merge:

  • ⛱️ I have completed this PR template in full and updated the title appropriately
  • [x ] ⛵ My code builds cleanly, and I have manually tested the changes
  • 🏄‍♂️ Another team member has built this branch and done manual testing on the change
  • 🏖️ New and existing unit tests pass locally and in CI
  • 🔱 The test plan has been implemented and verified by an SDET
  • 🦀 Automated tests have been written and added to this PR
  • 🐬 I have commented my code, particularly in hard-to-understand areas
  • [x ] 🤿 Corresponding changes have been made to all documentation
  • 🐚 Required changes to the VScE have been made
  • 🪸 Required updates to scaffolds have been made
  • 🚢 The release checklist has been completed

🛩️ Summary of Changes

changed some worried in a cod and removed an extra line of code from the example

🎢 Test Plan

to follow the doc instructions now with the fix and not have errors

🛸 Type of Change

  • 🧽 Chore ➾
  • [x ] 🛠️ Fix ➾
  • ✨ Feature ➾
  • 👷 Refactor ➾
  • 🧪 Pre-Release ➾
  • 🚀 Release ➾

@michaelkernaghan michaelkernaghan requested a review from a team November 21, 2022 18:58
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 21, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d980660
Status: ✅  Deploy successful!
Preview URL: https://a2b6f9bd.taqueria.pages.dev
Branch Preview URL: https://mk-1478-taco-shop-doc-correc.taqueria.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2022

Latest Commit d980660
Taq Binaries

Linux
MacOS
Windows

npm Packages

npm i @taqueria/plugin-archetype@0.22.2-1527.d9806602 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-contract-types@0.22.2-1527.d9806602 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-core@0.22.2-1527.d9806602 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-flextesa@0.22.2-1527.d9806602 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-ipfs-pinata@0.22.2-1527.d9806602 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-jest@0.22.2-1527.d9806602 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-ligo@0.22.2-1527.d9806602 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-metadata@0.22.2-1527.d9806602 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-smartpy@0.22.2-1527.d9806602 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-taquito@0.22.2-1527.d9806602 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-tezos-client@0.22.2-1527.d9806602 --registry https://npm.ecadinfra.com
npm i @taqueria/protocol@0.22.2-1527.d9806602 --registry https://npm.ecadinfra.com
npm i @taqueria/node-sdk@0.22.2-1527.d9806602 --registry https://npm.ecadinfra.com
npm i @taqueria/state@0.22.2-1527.d9806602 --registry https://npm.ecadinfra.com
npm i @taqueria/toolkit@0.22.2-1527.d9806602 --registry https://npm.ecadinfra.com
npm i @0.22.2-1527.d9806602 --registry https://npm.ecadinfra.com

VSCode Extension VSIX

taqueria-vscode-mk-1478-taco-shop-doc-correction-ubuntu-latest

@hu3man hu3man merged commit 74e76d0 into main Nov 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2022
@hu3man hu3man deleted the mk-1478-taco-shop-doc-correction branch December 8, 2022 09:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug ➾ in the Taco-shop Scaffold docs, there is a linter error for the suggested aps.tsx code
3 participants