Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Refactor ➾ (ci) move tests to self-hosted Mac Minis #1509

Merged
merged 11 commits into from
Nov 18, 2022

Conversation

GImbrailo
Copy link
Contributor

@GImbrailo GImbrailo commented Nov 17, 2022

🌮 Taqueria PR

🪁 Description

We want to run our E2E tests on our self-hosted runners on Mac Minis. The tests run significantly faster on the self-hosted runners.

🪂 Pre-Merge Checklist (Definition of Done)

🚦 Required to merge:

  • ⛱️ I have completed this PR template in full and updated the title appropriately
  • ⛵ My code builds cleanly, and I have manually tested the changes

🛩️ Summary of Changes

  • Change the runner tag from macOS-latest to ecad-macmini for the run-tests job
  • Remove caching as this often has a negative impact on the workflows and can make them take longer due to network restraints
  • Remove the --maxWorkers=1 option for e2e tests to run tests in parallel.

🛸 Type of Change

  • 👷 Refactor ➾

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 17, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 51c5a89
Status: ✅  Deploy successful!
Preview URL: https://418ac6c6.taqueria.pages.dev
Branch Preview URL: https://tests-on-self-hosted-macmini.taqueria.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2022

Latest Commit 51c5a89
Taq Binaries

Linux
MacOS
Windows

npm Packages

npm i @taqueria/plugin-archetype@0.22.2-1509.51c5a899 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-contract-types@0.22.2-1509.51c5a899 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-core@0.22.2-1509.51c5a899 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-flextesa@0.22.2-1509.51c5a899 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-ipfs-pinata@0.22.2-1509.51c5a899 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-jest@0.22.2-1509.51c5a899 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-ligo@0.22.2-1509.51c5a899 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-metadata@0.22.2-1509.51c5a899 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-smartpy@0.22.2-1509.51c5a899 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-taquito@0.22.2-1509.51c5a899 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-tezos-client@0.22.2-1509.51c5a899 --registry https://npm.ecadinfra.com
npm i @taqueria/protocol@0.22.2-1509.51c5a899 --registry https://npm.ecadinfra.com
npm i @taqueria/node-sdk@0.22.2-1509.51c5a899 --registry https://npm.ecadinfra.com
npm i @taqueria/state@0.22.2-1509.51c5a899 --registry https://npm.ecadinfra.com
npm i @taqueria/toolkit@0.22.2-1509.51c5a899 --registry https://npm.ecadinfra.com
npm i @0.22.2-1509.51c5a899 --registry https://npm.ecadinfra.com

VSCode Extension VSIX

taqueria-vscode-tests-on-self-hosted-macminis-ubuntu-latest

@GImbrailo GImbrailo self-assigned this Nov 17, 2022
@GImbrailo GImbrailo marked this pull request as ready for review November 17, 2022 17:40
@GImbrailo GImbrailo requested a review from a team as a code owner November 17, 2022 17:40
@GImbrailo GImbrailo requested a review from a team November 17, 2022 17:40
Copy link
Contributor

@danielelisi danielelisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small comment for lerna bootstrap. Other than than LGTM.


- name: Build all
run: |
npx lerna bootstrap
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest adding --force-local to ensure local packages are linked

@danielelisi
Copy link
Contributor

I see one of the build main / OS ubuntu-latest test chunk 0 (pull_request) failing. Is that expected?

Copy link
Contributor

@hu3man hu3man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super excited to see this go live, great work @GImbrailo !

@GImbrailo GImbrailo merged commit 77a354e into main Nov 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants