Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for unset signals or unused bits in the frame should be '1' for J1939 #581

Open
linzbdav opened this issue Jun 23, 2021 · 3 comments
Assignees
Labels

Comments

@linzbdav
Copy link

The default value for unset signals or unused bits in the frame is currently set to '0' but the document SAE J1939-71 in Table 1 defines if a signal is not available or nor requested the value should be 0xFF. Therefore the unset signals ans unused bits should be set to '1'.

@ebroecker ebroecker added the bug label Jul 6, 2021
@ebroecker ebroecker self-assigned this Mar 31, 2022
@ebroecker
Copy link
Owner

hi @linzbdav

I was just looking to this issue...

Not sure how to fix this compatible, because I think default value should be 0 for normal can and seems it should be 1 (0xff) for j1939.

What use case you came along with this bug (converting, creation, what ever)?
I just want to know this to find a useful workaround ...

@linzbdav
Copy link
Author

Hi @ebroecker
Sorry for my late response I was very busy during the last days. I use the library for creation of CAN-frames, I use a dbc file with all message definition and want to generate the frame with, some messages don't use all bits or I don't want to set a signal then the resulting value in the message should be filled with ones.

@ebroecker
Copy link
Owner

ebroecker commented Jul 18, 2023

Hi @linzbdav

do you use canmatrix to create the frame? With encode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants