Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlitCommandEncoder.CopyFromTexture doesn't work #290

Open
1 of 6 tasks
TotallyGamerJet opened this issue Oct 19, 2024 · 1 comment
Open
1 of 6 tasks

BlitCommandEncoder.CopyFromTexture doesn't work #290

TotallyGamerJet opened this issue Oct 19, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@TotallyGamerJet
Copy link
Collaborator

TotallyGamerJet commented Oct 19, 2024

PureGo Version

main

Operating System

  • Windows
  • macOS
  • Linux
  • FreeBSD
  • Android
  • iOS

Go Version (go version)

go version go1.22.1 darwin/arm64

What steps will reproduce the problem?

See hajimehoshi/ebiten#3135

In github.com/hajimehoshi/ebitengine:
CGO_ENABLED=1 GOARCH=amd64 go run examples/2048/main.go

What is the expected result?

Either purego should properly panic that there are too many arguments or it should work as expected

What happens instead?

It crashes with an OS error:

2024-10-19 23:20:43.969 2048[80611:175264348] [CAMetalLayer nextDrawable] returning nil because allocation failed.
-[IOGPUMetalCommandBuffer validate]:216: failed assertion `commit command buffer with uncommitted encoder'
SIGABRT: abort
PC=0x7ff8058c714a m=4 sigcode=0
signal arrived during cgo execution

Anything else you feel useful to add?

I think it's better to error then to add support for more arguments

@TotallyGamerJet TotallyGamerJet added the bug Something isn't working label Oct 19, 2024
@hajimehoshi
Copy link
Member

I think it's better to error then to add support for more arguments

I agree. Let's have a better error message, and revisit this whenever we want :)

@hajimehoshi hajimehoshi added this to the v0.9.0 milestone Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants