From 31bfef7351efaa0649b0e97a71bcbcc4626096bb Mon Sep 17 00:00:00 2001 From: Alex Boten Date: Wed, 14 Jun 2023 08:18:27 -0700 Subject: [PATCH] [chore] bump go version for linting (#23346) After digging into what was causing linting time outs, it looks like golangci-lint was using up a significant amount of memory to run lint against otelcontribcol. After digging I came across this issue that mentions memory usage: golangci/golangci-lint#3565 (comment) I've tested bumping the linters to go 1.20 and so far it looks like the avg memory is lower than it was w/ go 1.19. I've also enabled verbose logging for linting to give us a bit more info when there are issues. --------- Signed-off-by: Alex Boten --- .github/workflows/build-and-test.yml | 2 +- Makefile.Common | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index e3da90e0747c..e32c9fb6061a 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -78,7 +78,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-go@v4 with: - go-version: 1.19 + go-version: "1.20" cache: false - name: Cache Go id: go-cache diff --git a/Makefile.Common b/Makefile.Common index 35f3fab0eef6..34bcd4e2f29e 100644 --- a/Makefile.Common +++ b/Makefile.Common @@ -155,7 +155,7 @@ fmt: $(GOIMPORTS) .PHONY: lint lint: $(LINT) checklicense misspell - $(LINT) run --allow-parallel-runners --build-tags integration --path-prefix $(shell basename "$(CURDIR)") + $(LINT) run --allow-parallel-runners --verbose --build-tags integration --path-prefix $(shell basename "$(CURDIR)") .PHONY: govulncheck govulncheck: $(GOVULNCHECK)