Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading --accept-eula configuration option and a wildcard proposal #3595

Closed
robert-mijakovic opened this issue Feb 25, 2021 · 0 comments · Fixed by #3630
Closed

Misleading --accept-eula configuration option and a wildcard proposal #3595

robert-mijakovic opened this issue Feb 25, 2021 · 0 comments · Fixed by #3630
Milestone

Comments

@robert-mijakovic
Copy link

Hi guys,

I think the '--accept-eula' configuration option is misleading.
There is already an easyconfig parameter of a very similar name, 'accept_eula', and of different data types, string vs bool.
Using the name '--accept-eula-for' instead would be more self-explanatory. The use case would be: '--accept-eula-for=AOCC,Intel-OneAPI'. I noticed that Kenneth already used such a name in PR #3535 but renamed it to --accept-eula.

To me, the configuration option naming, '--accept-eula', implies boolean type. The first time I saw the option, I thought I need to specify True to accept it. I did it and noticed that it didn't work. Checking Github and the documentation, I figured out that I need to specify the package for which I accept EULA.

On top of that, one should specify for which packages he accepts EULA. In most cases, one doesn't care and thus wants to specify that he accepts them all but in the current state cannot. Therefore, I propose to add a wildcard '*' which means that he accepts EULA for all packages he installs.

Best regards,
Robert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants