Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defining $EBVAR env vars should be deprecated/dropped #1219

Open
boegel opened this issue Mar 11, 2015 · 2 comments
Open

defining $EBVAR env vars should be deprecated/dropped #1219

boegel opened this issue Mar 11, 2015 · 2 comments
Milestone

Comments

@boegel
Copy link
Member

boegel commented Mar 11, 2015

the motivation for having these around is pretty broken:

from easybuild/tools/toolchain/toolchain.py:

442             # also set unique named variables that can be used in Makefiles
443             # - so you can have 'CFLAGS = $(EBVARCFLAGS)'
444             # -- 'CLFLAGS = $(CFLAGS)' gives  '*** Recursive variable `CFLAGS'
445             # references itself (eventually).  Stop' error
446             setvar("EBVAR%s" % key, val)
@wpoely86
Copy link
Member

The := assignment expanded immediately so when you do something like:

A =
CFLAGS = -Wall ${A}

where A gets filled in later in a makefile, you cannot switch to :=. To avoid recursive issues, you need a EBVAR variable.

@boegel
Copy link
Member Author

boegel commented May 24, 2017

@wpoely86 Do you mind issuing a PR to clarify the comment why $EBVAR variables are also being defined, and to add a test to check whether they're being set (so we don't break this accidentally)?

Worth mentioning: $EBVARCFLAGS & co are required for the patch for FSL added in easybuilders/easybuild-easyconfigs#4614

@boegel boegel modified the milestones: 3.3.0, 3.x May 24, 2017
@boegel boegel modified the milestones: 3.3.0, 3.4.0 Jun 22, 2017
@boegel boegel modified the milestones: 3.5.0, 3.4.0 Sep 4, 2017
@boegel boegel modified the milestones: 3.5.0, next release Dec 6, 2017
@boegel boegel modified the milestones: 3.5.1, 3.6.0 Jan 12, 2018
@boegel boegel modified the milestones: 3.5.2, 3.x Feb 22, 2018
@boegel boegel modified the milestones: 3.x, 4.x Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants