Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including FlexiBLAS as the default BLAS in foss will require easyblock changes #2421

Closed
ocaisa opened this issue May 12, 2021 · 7 comments
Closed

Comments

@ocaisa
Copy link
Member

ocaisa commented May 12, 2021

A first search indicates (at least):

@ocaisa
Copy link
Member Author

ocaisa commented May 12, 2021

I think the numpy one in particular needs to be tackled before we merge the SciPy bundle for 2021a

@boegel
Copy link
Member

boegel commented May 12, 2021

As discussed in today's EB conf call: we should also come up with a way to detect unintentional direct linking to libraries like OpenBLAS, probably by enhancing the sanity check in framework, perhaps specifically for toolchains that include FlexiBLAS as a component?
We can definitely leverage some of the existing stuff that is used for the RPATH sanity check...

@boegel
Copy link
Member

boegel commented May 24, 2021

@ocaisa The numpy easyblock doesn't need any changes at all to link correctly with FlexiBLAS, verified with easybuilders/easybuild-easyconfigs#12935 .

@boegel boegel modified the milestones: 4.4.0, release after 4.4.0 May 26, 2021
@branfosj
Copy link
Member

branfosj commented Jun 3, 2021

Building R (4.1.0) in 2021a I get:

WARNING: R will be built with generic BLAS, which will result in poor performance.

So, flexiblas is not being detected / used.

@branfosj
Copy link
Member

branfosj commented Jun 3, 2021

Building R (4.1.0) in 2021a I get:

WARNING: R will be built with generic BLAS, which will result in poor performance.

So, flexiblas is not being detected / used.

The R configure script has a library flag (-lopenblas, etc.) to BLAS library name translation section. This does not know about FlexiBLAS and the default is to identify it as a generic BLAS library. The R easyblock picks this up as an issue and warns us.

@boegel
Copy link
Member

boegel commented Mar 1, 2023

@ocaisa Should we still keep this open?

@ocaisa
Copy link
Member Author

ocaisa commented Mar 2, 2023

Well, since we check for linking to openblas now, I think this can be closed. The issue will present it self when a pr is made for the relevant easyblocks

@ocaisa ocaisa closed this as completed Mar 2, 2023
@boegel boegel modified the milestones: release after 4.7.1, 4.7.1 Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants