Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review terminology page #119

Closed
boegel opened this issue Feb 28, 2023 · 4 comments
Closed

review terminology page #119

boegel opened this issue Feb 28, 2023 · 4 comments
Assignees
Labels

Comments

@boegel
Copy link
Member

boegel commented Feb 28, 2023

https://docs.easybuild.io/terminology

@PetrKralCZ
Copy link
Collaborator

  • the |version| in the sentence: "In EasyBuild version |version| the framework source code consists of about 19000 lines of code"
  • quite an old version in the sentence: "EasyBuild version 2.4.0 includes 154 software-specific easyblocks and 28 generic easyblocks"
  • Everything else seems OK to me.

@boegel boegel moved this from Assigned to In Progress in Review docs (2023) Mar 15, 2023
@boegel
Copy link
Member Author

boegel commented Mar 29, 2023

Instead of |version|, we can use {{ easybuild.version }} (see how it's used in docs/index.md).
That will probably only work outside of code blocks though (to be checked).

That sentence only mentioning an ancient EasyBuild version can be removed - correct counts are kept on top of https://docs.easybuild.io/release-notes .

@PetrKralCZ Are you up for making a small PR for this?

@PetrKralCZ
Copy link
Collaborator

@boegel
Copy link
Member Author

boegel commented May 23, 2023

fixed in #133

@boegel boegel closed this as completed May 23, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Review docs (2023) May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants