This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Acb/update buildkit #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
dockerfile: fix git version detection
Signed-off-by: Justin Chadwell <me@jedevc.com>
This avoids wrong metadata matches on small files Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Add support for heredocs in the ONBUILD command
Allow none differ on local source to avoid false Dockerfile matches
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Improve build errors and remove useless grpc prefix
progressui: print logs for failed step as summary in plain mode
Previously, heredoc names were restricted to simple alphanumeric strings. However, heredocs should support much more complex use-cases, including quoting anywhere, as well as allowing special symbols like `.` for easily expressing file extensions. This patch adds support for these more complex cases, by using the shell lexer to parse each heredoc name. Additionally, we include improvements to the lexer to optionally preserve escape tokens to avoid problems when lexing words that have already been lexed before. Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Finalize was only used outside the cache package in one place, which
called it with the commit arg set to false. The code path followed
when commit==false turned out to essentially be a no-op because
it set "retain cache" to true if it was already set to true.
It was thus safe to remove the only external call to it and remove it
from the interface. This should be helpful for future efforts to
simplify the equal{Mutable,Immutable} fields in cacheRecord, which exist
due to the "lazy commit" feature that Finalize is tied into.
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
Improve heredoc parsing to allow more generic shell-words
Improve progress and history messages for heredoc-related commands
Remove unneeded Finalize method from ImmutableRef.
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
Fix ref leak if fileop ref fails to mount.
Remove duplicate "not found" from some error messages
contenthash: use SeekLowerBound to seek radix tree
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
enable riscv64 build
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: Jacob MacElroy <jacob@okteto.com>
…tion converter: make sure uncompressed digest annotation is set
Use gha cache on CI
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
limited: fix possible deadlock when pushhandler calls fetcher
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
README.md: improve "Building multi-platform images" section
Add support for ulimit
Creating tcp socket without using go-connections.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
The problem this change is trying to fix are the environments where some capabilities are already dropped, so they can't be granted to the job with `--security=insecure`. I know that probably fixed set of capabilities was implemented to provide a stable build environment, but at the same time this breaks environments with reduced capabilities. Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com>
fix: provide only available capabilities to insecure environment
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
client: allow setting custom dialer for session endpoint
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
add size to tmpfs mounts
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
use bytes as given size for tmpfs mount
solver: fix exporters unsafely sharing records
It turns out that while Buildkit code did not need this method to be public, moby code does still use it, so we have to re-add it after its removal in moby#2216 (commit b85ef15). This commit is not a revert because some of the changes are still desireable, namely the removal of the "commit" parameter which didn't serve any purpose. Signed-off-by: Erik Sipsma <erik@sipsma.dev>
Re-add Finalize method to ImmutableRef.
vladaionescu
approved these changes
Oct 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example of this branch (
4a0195f75613c2b65886256d1b6a219df8708ae1) working with earthly: earthly/earthly#1355