Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent formatting #111

Closed
Peter9192 opened this issue Jun 16, 2021 · 2 comments · Fixed by #239
Closed

Consistent formatting #111

Peter9192 opened this issue Jun 16, 2021 · 2 comments · Fixed by #239
Assignees
@sverhoeven
Milestone
v1.2.0

Comments

@Peter9192
Copy link
Collaborator

I don't think we've settled on a default formatter for this repo, have we? I suggest to use black, just like in the comparison.
@Peter9192
Copy link
Collaborator Author

I updated all the notebooks, but we should add the instructions to the contributing and format the codebase. Also add a linter to GH actions?

@Peter9192 Peter9192 added this to the eWaterCycle v1.1.0 milestone Jul 26, 2021
@sverhoeven sverhoeven modified the milestones: eWaterCycle v1.1.0, v1.2.0 Aug 10, 2021
@sverhoeven sverhoeven self-assigned this Aug 10, 2021
@sverhoeven sverhoeven mentioned this issue Aug 10, 2021
Merged
@sverhoeven
Copy link
Member

Black will be run on pre-commit and linter shows warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sverhoeven sverhoeven

Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

Adds black and pre-commit hooks eWaterCycle/ewatercycle
2 participants
@sverhoeven @Peter9192