From f0686afe0afc977db1b31e66b236ca0543a5362e Mon Sep 17 00:00:00 2001 From: elianalf <62831776+elianalf@users.noreply.github.com> Date: Thu, 25 Apr 2024 09:36:36 +0200 Subject: [PATCH] Refs #20819: Make TimedEvent private Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> --- include/fastrtps/rtps/resources/TimedEvent.h | 25 ------------------- src/cpp/fastdds/publisher/DataWriterImpl.cpp | 2 +- src/cpp/fastdds/subscriber/DataReaderImpl.cpp | 2 +- .../builtin/data/ParticipantProxyData.cpp | 2 +- .../DS/PDPSecurityInitiatorListener.cpp | 2 +- .../builtin/discovery/participant/PDP.cpp | 2 +- .../discovery/participant/PDPListener.cpp | 2 +- .../discovery/participant/PDPSimple.cpp | 2 +- .../participant/timedevent/DSClientEvent.h | 2 +- .../participant/timedevent/DServerEvent.hpp | 2 +- src/cpp/rtps/builtin/liveliness/WLP.cpp | 2 +- src/cpp/rtps/reader/WriterProxy.cpp | 2 +- src/cpp/rtps/resources/TimedEvent.cpp | 2 +- .../cpp}/rtps/resources/TimedEvent.h | 0 src/cpp/rtps/resources/TimedEventImpl.h | 2 +- src/cpp/rtps/security/SecurityManager.h | 3 +-- src/cpp/rtps/writer/LivelinessManager.hpp | 3 +-- src/cpp/rtps/writer/ReaderProxy.cpp | 15 ++++++----- src/cpp/rtps/writer/StatefulWriter.cpp | 2 +- .../rtps/monitor-service/MonitorService.hpp | 2 +- .../{fastdds => }/rtps/resources/TimedEvent.h | 0 .../rtps/reader/WriterProxyAcknackTests.cpp | 4 +-- .../rtps/reader/WriterProxyStopTest.cpp | 4 +-- .../unittest/rtps/reader/WriterProxyTests.cpp | 4 +-- .../resources/timedevent/mock/MockEvent.h | 2 +- .../rtps/monitor-service/MonitorService.hpp | 2 +- 26 files changed, 29 insertions(+), 63 deletions(-) delete mode 100644 include/fastrtps/rtps/resources/TimedEvent.h rename {include/fastdds => src/cpp}/rtps/resources/TimedEvent.h (100%) rename test/mock/rtps/TimedEvent/{fastdds => }/rtps/resources/TimedEvent.h (100%) diff --git a/include/fastrtps/rtps/resources/TimedEvent.h b/include/fastrtps/rtps/resources/TimedEvent.h deleted file mode 100644 index f61eac2a567..00000000000 --- a/include/fastrtps/rtps/resources/TimedEvent.h +++ /dev/null @@ -1,25 +0,0 @@ -// Copyright 2016 Proyectos y Sistemas de Mantenimiento SL (eProsima). -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -/** - * @file TimedEvent.h - * - */ - -#ifndef _RTPS_RESOURCES_TIMEDEVENT_H_ -#define _RTPS_RESOURCES_TIMEDEVENT_H_ - -#include - -#endif //_RTPS_RESOURCES_TIMEDEVENT_H_ diff --git a/src/cpp/fastdds/publisher/DataWriterImpl.cpp b/src/cpp/fastdds/publisher/DataWriterImpl.cpp index 85000195b4e..8efef889650 100644 --- a/src/cpp/fastdds/publisher/DataWriterImpl.cpp +++ b/src/cpp/fastdds/publisher/DataWriterImpl.cpp @@ -39,7 +39,6 @@ #include #include #include -#include #include #include #include @@ -50,6 +49,7 @@ #include #include #include +#include #include #ifdef FASTDDS_STATISTICS diff --git a/src/cpp/fastdds/subscriber/DataReaderImpl.cpp b/src/cpp/fastdds/subscriber/DataReaderImpl.cpp index 11653e7ace5..365c5d42585 100644 --- a/src/cpp/fastdds/subscriber/DataReaderImpl.cpp +++ b/src/cpp/fastdds/subscriber/DataReaderImpl.cpp @@ -39,7 +39,6 @@ #include #include #include -#include #include #include #include @@ -50,6 +49,7 @@ #include #include +#include #include #ifdef FASTDDS_STATISTICS diff --git a/src/cpp/rtps/builtin/data/ParticipantProxyData.cpp b/src/cpp/rtps/builtin/data/ParticipantProxyData.cpp index c06e5337d9e..d6e6692c113 100644 --- a/src/cpp/rtps/builtin/data/ParticipantProxyData.cpp +++ b/src/cpp/rtps/builtin/data/ParticipantProxyData.cpp @@ -28,11 +28,11 @@ #include #include #include -#include #include #include #include +#include #include #include diff --git a/src/cpp/rtps/builtin/discovery/participant/DS/PDPSecurityInitiatorListener.cpp b/src/cpp/rtps/builtin/discovery/participant/DS/PDPSecurityInitiatorListener.cpp index 6a6dc849263..fd8d4fcbbbd 100644 --- a/src/cpp/rtps/builtin/discovery/participant/DS/PDPSecurityInitiatorListener.cpp +++ b/src/cpp/rtps/builtin/discovery/participant/DS/PDPSecurityInitiatorListener.cpp @@ -27,7 +27,6 @@ #include #include #include -#include #include #include @@ -35,6 +34,7 @@ #include #include #include +#include using ParameterList = eprosima::fastdds::dds::ParameterList; diff --git a/src/cpp/rtps/builtin/discovery/participant/PDP.cpp b/src/cpp/rtps/builtin/discovery/participant/PDP.cpp index 89989335e65..a57349827bd 100644 --- a/src/cpp/rtps/builtin/discovery/participant/PDP.cpp +++ b/src/cpp/rtps/builtin/discovery/participant/PDP.cpp @@ -35,7 +35,6 @@ #include #include #include -#include #include #include @@ -49,6 +48,7 @@ #include #include #include +#include #include #include #include diff --git a/src/cpp/rtps/builtin/discovery/participant/PDPListener.cpp b/src/cpp/rtps/builtin/discovery/participant/PDPListener.cpp index 98aee8fc88f..7cb29a8f696 100644 --- a/src/cpp/rtps/builtin/discovery/participant/PDPListener.cpp +++ b/src/cpp/rtps/builtin/discovery/participant/PDPListener.cpp @@ -27,13 +27,13 @@ #include #include #include -#include #include #include #include #include #include +#include #ifdef FASTDDS_STATISTICS #include #endif //FASTDDS_STATISTICS diff --git a/src/cpp/rtps/builtin/discovery/participant/PDPSimple.cpp b/src/cpp/rtps/builtin/discovery/participant/PDPSimple.cpp index 62cc45d910c..769eb45b73a 100644 --- a/src/cpp/rtps/builtin/discovery/participant/PDPSimple.cpp +++ b/src/cpp/rtps/builtin/discovery/participant/PDPSimple.cpp @@ -30,7 +30,6 @@ #include #include #include -#include #include #include @@ -45,6 +44,7 @@ #include #include #include +#include namespace eprosima { namespace fastrtps { diff --git a/src/cpp/rtps/builtin/discovery/participant/timedevent/DSClientEvent.h b/src/cpp/rtps/builtin/discovery/participant/timedevent/DSClientEvent.h index e52ba8e05bc..06f95325635 100644 --- a/src/cpp/rtps/builtin/discovery/participant/timedevent/DSClientEvent.h +++ b/src/cpp/rtps/builtin/discovery/participant/timedevent/DSClientEvent.h @@ -21,7 +21,7 @@ #define _FASTDDS_RTPS_DSCLIENTEVENT_H_ #ifndef DOXYGEN_SHOULD_SKIP_THIS_PUBLIC -#include +#include namespace eprosima { namespace fastdds { diff --git a/src/cpp/rtps/builtin/discovery/participant/timedevent/DServerEvent.hpp b/src/cpp/rtps/builtin/discovery/participant/timedevent/DServerEvent.hpp index b0efdf9c469..425e69144da 100644 --- a/src/cpp/rtps/builtin/discovery/participant/timedevent/DServerEvent.hpp +++ b/src/cpp/rtps/builtin/discovery/participant/timedevent/DServerEvent.hpp @@ -21,7 +21,7 @@ #define _FASTDDS_RTPS_DSERVEREVENT2_H_ #ifndef DOXYGEN_SHOULD_SKIP_THIS_PUBLIC -#include +#include namespace eprosima { namespace fastdds { diff --git a/src/cpp/rtps/builtin/liveliness/WLP.cpp b/src/cpp/rtps/builtin/liveliness/WLP.cpp index 123aa2f4dd2..2e62081f1d1 100644 --- a/src/cpp/rtps/builtin/liveliness/WLP.cpp +++ b/src/cpp/rtps/builtin/liveliness/WLP.cpp @@ -29,7 +29,6 @@ #include #include #include -#include #include #include @@ -39,6 +38,7 @@ #include #include #include +#include #include #include diff --git a/src/cpp/rtps/reader/WriterProxy.cpp b/src/cpp/rtps/reader/WriterProxy.cpp index 55f3a741855..7fc1988669d 100644 --- a/src/cpp/rtps/reader/WriterProxy.cpp +++ b/src/cpp/rtps/reader/WriterProxy.cpp @@ -23,7 +23,6 @@ #include #include #include -#include #include #include "rtps/RTPSDomainImpl.hpp" @@ -31,6 +30,7 @@ #include #include #include +#include #if !defined(NDEBUG) && !defined(ANDROID) && defined(FASTDDS_SOURCE) && defined(__unix__) #define SHOULD_DEBUG_LINUX diff --git a/src/cpp/rtps/resources/TimedEvent.cpp b/src/cpp/rtps/resources/TimedEvent.cpp index 5b83b1640ce..1377e840b8a 100644 --- a/src/cpp/rtps/resources/TimedEvent.cpp +++ b/src/cpp/rtps/resources/TimedEvent.cpp @@ -17,7 +17,7 @@ * */ -#include +#include #include #include "TimedEventImpl.h" diff --git a/include/fastdds/rtps/resources/TimedEvent.h b/src/cpp/rtps/resources/TimedEvent.h similarity index 100% rename from include/fastdds/rtps/resources/TimedEvent.h rename to src/cpp/rtps/resources/TimedEvent.h diff --git a/src/cpp/rtps/resources/TimedEventImpl.h b/src/cpp/rtps/resources/TimedEventImpl.h index 01ab3c8cdbb..a36f767c279 100644 --- a/src/cpp/rtps/resources/TimedEventImpl.h +++ b/src/cpp/rtps/resources/TimedEventImpl.h @@ -23,7 +23,7 @@ #ifndef DOXYGEN_SHOULD_SKIP_THIS_PUBLIC #include -#include +#include #include #include diff --git a/src/cpp/rtps/security/SecurityManager.h b/src/cpp/rtps/security/SecurityManager.h index f2da36a54b0..ee3807a927b 100644 --- a/src/cpp/rtps/security/SecurityManager.h +++ b/src/cpp/rtps/security/SecurityManager.h @@ -32,10 +32,9 @@ #include #include #include -#include #include #include - +#include #include #include #include diff --git a/src/cpp/rtps/writer/LivelinessManager.hpp b/src/cpp/rtps/writer/LivelinessManager.hpp index d2f811afc33..4a37c5599b4 100644 --- a/src/cpp/rtps/writer/LivelinessManager.hpp +++ b/src/cpp/rtps/writer/LivelinessManager.hpp @@ -20,9 +20,8 @@ #include -#include #include - +#include #include #include diff --git a/src/cpp/rtps/writer/ReaderProxy.cpp b/src/cpp/rtps/writer/ReaderProxy.cpp index 005ad3e7716..3a567292fd3 100644 --- a/src/cpp/rtps/writer/ReaderProxy.cpp +++ b/src/cpp/rtps/writer/ReaderProxy.cpp @@ -17,24 +17,23 @@ * */ +#include + +#include +#include +#include #include #include -#include #include -#include -#include #include - #include #include - #include "rtps/messages/RTPSGapBuilder.hpp" #include +#include +#include -#include -#include -#include namespace eprosima { namespace fastrtps { diff --git a/src/cpp/rtps/writer/StatefulWriter.cpp b/src/cpp/rtps/writer/StatefulWriter.cpp index ec2b10342dc..c3a31dba31c 100644 --- a/src/cpp/rtps/writer/StatefulWriter.cpp +++ b/src/cpp/rtps/writer/StatefulWriter.cpp @@ -31,7 +31,6 @@ #include #include #include -#include #include #include #include @@ -47,6 +46,7 @@ #include #include #include +#include #include #ifdef FASTDDS_STATISTICS diff --git a/src/cpp/statistics/rtps/monitor-service/MonitorService.hpp b/src/cpp/statistics/rtps/monitor-service/MonitorService.hpp index 14d90c0bd3a..6044017c2b5 100644 --- a/src/cpp/statistics/rtps/monitor-service/MonitorService.hpp +++ b/src/cpp/statistics/rtps/monitor-service/MonitorService.hpp @@ -30,11 +30,11 @@ #include #include #include -#include #include #include "Interfaces.hpp" #include +#include #include #include #include diff --git a/test/mock/rtps/TimedEvent/fastdds/rtps/resources/TimedEvent.h b/test/mock/rtps/TimedEvent/rtps/resources/TimedEvent.h similarity index 100% rename from test/mock/rtps/TimedEvent/fastdds/rtps/resources/TimedEvent.h rename to test/mock/rtps/TimedEvent/rtps/resources/TimedEvent.h diff --git a/test/unittest/rtps/reader/WriterProxyAcknackTests.cpp b/test/unittest/rtps/reader/WriterProxyAcknackTests.cpp index e3a203f670d..6d75c509181 100644 --- a/test/unittest/rtps/reader/WriterProxyAcknackTests.cpp +++ b/test/unittest/rtps/reader/WriterProxyAcknackTests.cpp @@ -24,12 +24,10 @@ #include #include #include -#include - #include #include - #include +#include #include "../../common/operators.hpp" diff --git a/test/unittest/rtps/reader/WriterProxyStopTest.cpp b/test/unittest/rtps/reader/WriterProxyStopTest.cpp index 038382f0894..bab10b6a294 100644 --- a/test/unittest/rtps/reader/WriterProxyStopTest.cpp +++ b/test/unittest/rtps/reader/WriterProxyStopTest.cpp @@ -21,12 +21,10 @@ #include #include #include -#include - #include #include - #include +#include namespace testing { namespace internal { diff --git a/test/unittest/rtps/reader/WriterProxyTests.cpp b/test/unittest/rtps/reader/WriterProxyTests.cpp index 649db33f020..493bc644bef 100644 --- a/test/unittest/rtps/reader/WriterProxyTests.cpp +++ b/test/unittest/rtps/reader/WriterProxyTests.cpp @@ -24,12 +24,10 @@ #include #include #include -#include - #include #include - #include +#include #include "../../common/operators.hpp" diff --git a/test/unittest/rtps/resources/timedevent/mock/MockEvent.h b/test/unittest/rtps/resources/timedevent/mock/MockEvent.h index dc00803d984..22b000fbcd4 100644 --- a/test/unittest/rtps/resources/timedevent/mock/MockEvent.h +++ b/test/unittest/rtps/resources/timedevent/mock/MockEvent.h @@ -21,7 +21,7 @@ #include -#include +#include class MockEvent { diff --git a/test/unittest/statistics/rtps/mock/StatisticsBase/statistics/rtps/monitor-service/MonitorService.hpp b/test/unittest/statistics/rtps/mock/StatisticsBase/statistics/rtps/monitor-service/MonitorService.hpp index 636a93084af..807cc46f717 100644 --- a/test/unittest/statistics/rtps/mock/StatisticsBase/statistics/rtps/monitor-service/MonitorService.hpp +++ b/test/unittest/statistics/rtps/mock/StatisticsBase/statistics/rtps/monitor-service/MonitorService.hpp @@ -30,10 +30,10 @@ #include #include #include -#include #include #include +#include #include #include #include