Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

floating-label: color adjustment #2503

Closed
1 task done
fwg001 opened this issue Dec 2, 2024 · 0 comments
Closed
1 task done

floating-label: color adjustment #2503

fwg001 opened this issue Dec 2, 2024 · 0 comments
Assignees
Milestone

Comments

@fwg001
Copy link

fwg001 commented Dec 2, 2024

I verified there's no existing issue for this bug.

  • There are no existing issues

Current behavior

Currently the floating label is black (Foreground/Primary) by default.
Skin: floating-label
eBayUI: form input ebay textbox floating

Check other related form components for consistency.

Expected behavior

Expected color token is Foreground/Secondary as default and hover, then on focus its Foreground/Primary.
Specs: Text Field

Skin version

18.5.0

Device/OS/Browser info

No response

Steps to reproduce

1.
2.
3.
...

Relevant code block

No response

Additional context

Reported by Varun Pullannagari
Link to slack thread: https://ebay-eng.slack.com/archives/C0RKTR82W/p1733175441383219

@agliga agliga added this to the 18.6.0 milestone Dec 3, 2024
@agliga agliga moved this to Todo in eBayUI Dec 10, 2024
@agliga agliga self-assigned this Dec 10, 2024
@agliga agliga moved this from Todo to Pull request in eBayUI Dec 11, 2024
@agliga agliga moved this from Pull request to Done in eBayUI Dec 18, 2024
@agliga agliga closed this as completed Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants