Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR - menu manager versus HTML layouts #3932

Closed
Jimmi08 opened this issue Aug 21, 2019 · 1 comment
Closed

FR - menu manager versus HTML layouts #3932

Jimmi08 opened this issue Aug 21, 2019 · 1 comment
Labels
type: enhancement An improvement or new feature request
Milestone

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Aug 21, 2019

There is a small limitation for Menu Manager now because it parses only {MENU=x} in theme.html and _layout.html files.

Now you can have different footer per layout very easy, so it's easier now. But there can exist a more complicated theme where you need to change footer or header on the fly or by extended functionality. But if they have menu areas (footers mainly), they are not displayed in Menu manager.

It would be great to have 2 special theme shortcodes that are parsed in Menu manager too if they are used in html layouts (theme or layouts).

Normal parsing (Frontend) works without any problems. Something like {THEME_CUSTOMHEADER} and {THEME_CUSTOMFOOTER}

Thanks

@CaMer0n CaMer0n added the type: enhancement An improvement or new feature request label Aug 22, 2019
@CaMer0n CaMer0n added this to the e107 2.2.2 milestone Aug 22, 2019
@CaMer0n
Copy link
Member

CaMer0n commented Aug 22, 2019

Modify bootstrap4/theme_shortcodes.php , method: sc_footer() to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement An improvement or new feature request
Projects
None yet
Development

No branches or pull requests

2 participants