Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onclick attribute gets stripped when last #3926

Closed
fsLeg opened this issue Aug 18, 2019 · 0 comments
Closed

onclick attribute gets stripped when last #3926

fsLeg opened this issue Aug 18, 2019 · 0 comments
Labels
status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. type: bug A problem that should not be happening
Milestone

Comments

@fsLeg
Copy link

fsLeg commented Aug 18, 2019

While editing one of my severely outdated pages I noticed one extremely annoying behavior: onclick attribute gets stripped if it's the last attribute of a tag.

Example of stripping (add this code to a page and save):

<a href="#" onclick="alert('Hey!');">Clicking on this link will do nothing.</a>

Example of not stripping:

<a onclick="alert('Hey!');" href="#">Clicking on this link will produce an alert.</a>

Considering that a lot of my links on certain pages are in form of buttons that rely on onclick attribute, quite a lot of information was lost due to me not knowing about this quirk.

I haven't tested this behavior outside of pages.

@Moc Moc added type: bug A problem that should not be happening status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. labels Aug 26, 2019
@Moc Moc modified the milestone: e107 2.2.2 Aug 26, 2019
@Moc Moc added this to the e107 2.2.2 milestone Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

2 participants