download icons - fix for bootstrap 4

[Jimmi08]

Problematic shortcode:
{DOWNLOAD_CAT_NEWDOWNLOAD_TEXT}
and probably there are others too.

it returns glyphicon icon.

FIX:

/* define images */
	if(deftrue('BOOTSTRAP') && BOOTSTRAP === 3)
	{
		define("IMAGE_DOWNLOAD", (file_exists(THEME."images/download.png") ? THEME."images/download.png" : 'icon-download.glyph'));
		define("IMAGE_NEW", (file_exists(THEME."images/new.png") ? THEME."images/new.png" : 'icon-star.glyph'));	
	}
	elseif(deftrue('BOOTSTRAP') && BOOTSTRAP === 4)
	{
		define("IMAGE_DOWNLOAD", (file_exists(THEME."images/download.png") ? THEME."images/download.png" : 'fa-download.glyph'));
		define("IMAGE_NEW", (file_exists(THEME."images/new.png") ? THEME."images/new.png" : 'fa-star.glyph'));	
	}	
	else 
	{
		define("IMAGE_DOWNLOAD", (file_exists(THEME."images/download.png") ? THEME."images/download.png" : e_IMAGE."generic/download.png"));
		define("IMAGE_NEW", (file_exists(THEME."images/new.png") ? THEME."images/new.png" : e_IMAGE."generic/new.png"));
	}

[Jimmi08]

Next one:

{DOWNLOAD_ADMIN_EDIT}

returns:
<i class="glyphicon glyphicon-edit"><!-- --></i>

but there is this code:
$icon = (deftrue('BOOTSTRAP')) ? e107::getParser()->toGlyph('edit') : "<img src='".e_IMAGE_ABS."generic/edit.png' alt='*' style='padding:0px;border:0px' />";

[CaMer0n]

@Jimmi08 Thanks. Just needs to be changed to toGlyph('fa-edit') instead of toGlyph('edit'). Pull-requests welcome. :-)